Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: webrtc/api/peerconnectioninterface.h

Issue 2641783002: Revert of New method StatsObserver::OnCompleteReports, passing ownership. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/peerconnection.cc ('k') | webrtc/api/test/mockpeerconnectionobservers.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 virtual MediaStreamTrackInterface* FindVideoTrack( 102 virtual MediaStreamTrackInterface* FindVideoTrack(
103 const std::string& id) = 0; 103 const std::string& id) = 0;
104 104
105 protected: 105 protected:
106 // Dtor protected as objects shouldn't be deleted via this interface. 106 // Dtor protected as objects shouldn't be deleted via this interface.
107 ~StreamCollectionInterface() {} 107 ~StreamCollectionInterface() {}
108 }; 108 };
109 109
110 class StatsObserver : public rtc::RefCountInterface { 110 class StatsObserver : public rtc::RefCountInterface {
111 public: 111 public:
112 // TODO(nisse, hbos): Old version, not passing ownership. Should 112 virtual void OnComplete(const StatsReports& reports) = 0;
113 // perhaps be deprecated, but since all of this is a legacy
114 // interface anyway, probably best to leave as is until this class
115 // can be deleted.
116 virtual void OnComplete(const StatsReports& reports) {}
117 virtual void OnCompleteReports(std::unique_ptr<StatsReports> reports) {
118 OnComplete(*reports);
119 }
120 113
121 protected: 114 protected:
122 virtual ~StatsObserver() {} 115 virtual ~StatsObserver() {}
123 }; 116 };
124 117
125 class MetricsObserverInterface : public rtc::RefCountInterface { 118 class MetricsObserverInterface : public rtc::RefCountInterface {
126 public: 119 public:
127 120
128 // |type| is the type of the enum counter to be incremented. |counter| 121 // |type| is the type of the enum counter to be incremented. |counter|
129 // is the particular counter in that type. |counter_max| is the next sequence 122 // is the particular counter in that type. |counter_max| is the next sequence
(...skipping 705 matching lines...) Expand 10 before | Expand all | Expand 10 after
835 cricket::WebRtcVideoEncoderFactory* encoder_factory, 828 cricket::WebRtcVideoEncoderFactory* encoder_factory,
836 cricket::WebRtcVideoDecoderFactory* decoder_factory) { 829 cricket::WebRtcVideoDecoderFactory* decoder_factory) {
837 return CreatePeerConnectionFactory( 830 return CreatePeerConnectionFactory(
838 worker_and_network_thread, worker_and_network_thread, signaling_thread, 831 worker_and_network_thread, worker_and_network_thread, signaling_thread,
839 default_adm, encoder_factory, decoder_factory); 832 default_adm, encoder_factory, decoder_factory);
840 } 833 }
841 834
842 } // namespace webrtc 835 } // namespace webrtc
843 836
844 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_ 837 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_
OLDNEW
« no previous file with comments | « webrtc/api/peerconnection.cc ('k') | webrtc/api/test/mockpeerconnectionobservers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698