Reland of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.

Reland of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.

Add RTC_DEPRACATed anonymous unions to not break downstream projects.

Orignal issue's description:
> commit 0ad21111fcc57a7e978edba3c4263f0062d7f9ff
> Author: danilchap <danilchap@webrtc.org>;
> Date:   Mon Dec 19 09:36:33 2016 -0800
>
>     Revert of Rename RTPVideoHeader.isFirstPacket to
>     .is_first_packet_in_frame. (patchset #1 id:1 of
>     https://codereview.webrtc.org/2574943003/ )
>
>     Reason for revert:
>     breaks downstream project.
>
>     Can you make this change in a compatible way using anonymous
>     union:
>     union {
>       bool is_first_packet_in_frame;
>       RTC_DEPRECATED bool isFirstPacket;
>     };
>     (unfortunetly this this treak breaks braced initialization in
>     rtp_rtcp_impl_unittest.cc,
>     so that should be rewritting in a more classic way)
>
>     Original issue's description:
>     > Rename RTPVideoHeader.isFirstPacket to
>     > .is_first_packet_in_frame.
>     >
>     > Name should represent the actual meaning.
>     >
>     > BUG=None
>     >
>     > Review-Url: https://codereview.webrtc.org/2574943003
>     > Cr-Commit-Position: refs/heads/master@{#15684}
>     > Committed:
>     > https://chromium.googlesource.com/external/webrtc/+/efde90838055f44ca05863ba020ca02c88b6d14c
>
>     TBR=stefan@webrtc.org,sprang@webrtc.org,johan@webrtc.org
>     # Skipping CQ checks because original CL landed less than 1 days
>     ago.
>     NOPRESUBMIT=true
>     NOTREECHECKS=true
>     NOTRY=true
>     BUG=None
>
>     Review-Url: https://codereview.webrtc.org/2589783003
>     Cr-Commit-Position: refs/heads/master@{#15686}
>

BUG=None

Review-Url: https://codereview.webrtc.org/2614503002
Cr-Commit-Position: refs/heads/master@{#15987}
Committed: https://chromium.googlesource.com/external/webrtc/+/0d1b2b688007be40a1c4b793a400d9e944462d28

[johan, 2017-01-03 17:39:33]

johan@webrtc.org changed reviewers:
+ danilchap@webrtc.org, sprang@webrtc.org

[johan, 2017-01-03 17:39:33]

@sprang: original reviewer.
@danilchap: you suggested the anonymous unions.

[johan, 2017-01-03 17:39:48]

The CQ bit was checked by johan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 17:39:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-03 18:30:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 18:30:42]

Dry run: This issue passed the CQ dry run.

[danilchap, 2017-01-04 10:13:28]

lgtm

https://codereview.webrtc.org/2614503002/diff/1/webrtc/modules/video_coding/p...
File webrtc/modules/video_coding/packet.h (right):

https://codereview.webrtc.org/2614503002/diff/1/webrtc/modules/video_coding/p...
webrtc/modules/video_coding/packet.h:43: RTC_DEPRECATED bool isFirstPacket;  //
Is this first packet in a frame.
#include "webrtc/base/deprecation.h"
to be safer

[johan, 2017-01-04 15:15:46]

The CQ bit was checked by johan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 15:15:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-04 15:17:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 15:17:39]

Dry run: This issue passed the CQ dry run.

[johan, 2017-01-04 15:21:32]

https://codereview.webrtc.org/2614503002/diff/1/webrtc/modules/video_coding/p...
File webrtc/modules/video_coding/packet.h (right):

https://codereview.webrtc.org/2614503002/diff/1/webrtc/modules/video_coding/p...
webrtc/modules/video_coding/packet.h:43: RTC_DEPRECATED bool isFirstPacket;  //
Is this first packet in a frame.
On 2017/01/04 10:13:27, danilchap wrote:
> #include "webrtc/base/deprecation.h"
> to be safer

Acknowledged.

[sprang_webrtc, 2017-01-09 13:21:27]

lgtm

[johan, 2017-01-09 14:50:54]

The CQ bit was checked by johan@webrtc.org

[johan, 2017-01-09 14:50:55]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2614503002/#ps20001 (title:
"Add base/deprecation.h include.")

[commit-bot: I haz the power, 2017-01-09 14:51:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-09 14:54:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 14:54:53]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11995)

[johan, 2017-01-09 15:19:11]

johan@webrtc.org changed reviewers:
+ stefan@webrtc.org

[johan, 2017-01-09 15:19:11]

Adding stefan as owner of   webrtc/modules/include/module_common_types.h . He
was already reviewer of the original patch.

[stefan-webrtc, 2017-01-10 12:14:47]

lgtm

[johan, 2017-01-10 12:17:55]

The CQ bit was checked by johan@webrtc.org

[commit-bot: I haz the power, 2017-01-10 12:18:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-10 12:18:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-10 12:21:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484050675867230,
"parent_rev": "989ec098d13525cf948926bcf403b03baa50e051", "commit_rev":
"0d1b2b688007be40a1c4b793a400d9e944462d28"}

[commit-bot: I haz the power, 2017-01-10 12:21:38]

Description was changed from

==========
Reland of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.

Add RTC_DEPRACATed anonymous unions to not break downstream projects.

Orignal issue's description:
> commit 0ad21111fcc57a7e978edba3c4263f0062d7f9ff
> Author: danilchap <danilchap@webrtc.org>
> Date:   Mon Dec 19 09:36:33 2016 -0800
>
>     Revert of Rename RTPVideoHeader.isFirstPacket to
>     .is_first_packet_in_frame. (patchset #1 id:1 of
>     https://codereview.webrtc.org/2574943003/ )
>
>     Reason for revert:
>     breaks downstream project.
>
>     Can you make this change in a compatible way using anonymous
>     union:
>     union {
>       bool is_first_packet_in_frame;
>       RTC_DEPRECATED bool isFirstPacket;
>     };
>     (unfortunetly this this treak breaks braced initialization in
>     rtp_rtcp_impl_unittest.cc,
>     so that should be rewritting in a more classic way)
>
>     Original issue's description:
>     > Rename RTPVideoHeader.isFirstPacket to
>     > .is_first_packet_in_frame.
>     >
>     > Name should represent the actual meaning.
>     >
>     > BUG=None
>     >
>     > Review-Url: https://codereview.webrtc.org/2574943003
>     > Cr-Commit-Position: refs/heads/master@{#15684}
>     > Committed:
>     >
https://chromium.googlesource.com/external/webrtc/+/efde90838055f44ca05863ba0...
>
>     TBR=stefan@webrtc.org,sprang@webrtc.org,johan@webrtc.org
>     # Skipping CQ checks because original CL landed less than 1 days
>     ago.
>     NOPRESUBMIT=true
>     NOTREECHECKS=true
>     NOTRY=true
>     BUG=None
>
>     Review-Url: https://codereview.webrtc.org/2589783003
>     Cr-Commit-Position: refs/heads/master@{#15686}
>

BUG=None
==========

to

==========
Reland of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.

Add RTC_DEPRACATed anonymous unions to not break downstream projects.

Orignal issue's description:
> commit 0ad21111fcc57a7e978edba3c4263f0062d7f9ff
> Author: danilchap <danilchap@webrtc.org>
> Date:   Mon Dec 19 09:36:33 2016 -0800
>
>     Revert of Rename RTPVideoHeader.isFirstPacket to
>     .is_first_packet_in_frame. (patchset #1 id:1 of
>     https://codereview.webrtc.org/2574943003/ )
>
>     Reason for revert:
>     breaks downstream project.
>
>     Can you make this change in a compatible way using anonymous
>     union:
>     union {
>       bool is_first_packet_in_frame;
>       RTC_DEPRECATED bool isFirstPacket;
>     };
>     (unfortunetly this this treak breaks braced initialization in
>     rtp_rtcp_impl_unittest.cc,
>     so that should be rewritting in a more classic way)
>
>     Original issue's description:
>     > Rename RTPVideoHeader.isFirstPacket to
>     > .is_first_packet_in_frame.
>     >
>     > Name should represent the actual meaning.
>     >
>     > BUG=None
>     >
>     > Review-Url: https://codereview.webrtc.org/2574943003
>     > Cr-Commit-Position: refs/heads/master@{#15684}
>     > Committed:
>     >
https://chromium.googlesource.com/external/webrtc/+/efde90838055f44ca05863ba0...
>
>     TBR=stefan@webrtc.org,sprang@webrtc.org,johan@webrtc.org
>     # Skipping CQ checks because original CL landed less than 1 days
>     ago.
>     NOPRESUBMIT=true
>     NOTREECHECKS=true
>     NOTRY=true
>     BUG=None
>
>     Review-Url: https://codereview.webrtc.org/2589783003
>     Cr-Commit-Position: refs/heads/master@{#15686}
>

BUG=None

Review-Url: https://codereview.webrtc.org/2614503002
Cr-Commit-Position: refs/heads/master@{#15987}
Committed:
https://chromium.googlesource.com/external/webrtc/+/0d1b2b688007be40a1c4b793a...
==========

[commit-bot: I haz the power, 2017-01-10 12:21:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/0d1b2b688007be40a1c4b793a...