Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2589783003: Revert of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame. (Closed)

Created:
4 years ago by danilchap
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame. (patchset #1 id:1 of https://codereview.webrtc.org/2574943003/ ) Reason for revert: breaks downstream project. Can you make this change in a compatible way using anonymous union: union { bool is_first_packet_in_frame; RTC_DEPRECATED bool isFirstPacket; }; (unfortunetly this this treak breaks braced initialization in rtp_rtcp_impl_unittest.cc, so that should be rewritting in a more classic way) Original issue's description: > Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame. > > Name should represent the actual meaning. > > BUG=None > > Review-Url: https://codereview.webrtc.org/2574943003 > Cr-Commit-Position: refs/heads/master@{#15684} > Committed: https://chromium.googlesource.com/external/webrtc/+/efde90838055f44ca05863ba020ca02c88b6d14c TBR=stefan@webrtc.org,sprang@webrtc.org,johan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2589783003 Cr-Commit-Position: refs/heads/master@{#15686} Committed: https://chromium.googlesource.com/external/webrtc/+/0ad21111fcc57a7e978edba3c4263f0062d7f9ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -215 lines) Patch
M webrtc/modules/include/module_common_types.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_video_generic.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp8.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp9.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/decoding_state_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/h264_sps_pps_tracker.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/h264_sps_pps_tracker_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/jitter_buffer_unittest.cc View 90 chunks +90 lines, -90 lines 0 comments Download
M webrtc/modules/video_coding/nack_module.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/video_coding/nack_module_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/packet.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/packet.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M webrtc/modules/video_coding/packet_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/session_info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/session_info_unittest.cc View 31 chunks +49 lines, -49 lines 0 comments Download
M webrtc/modules/video_coding/test/stream_generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_robustness_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/video_packet_buffer_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
danilchap
Created Revert of Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.
4 years ago (2016-12-19 17:36:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2589783003/1
4 years ago (2016-12-19 17:36:21 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-19 17:36:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/0ad21111fcc57a7e978edba3c...

Powered by Google App Engine
This is Rietveld 408576698