Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.

Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.

Name should represent the actual meaning.

BUG=None

Review-Url: https://codereview.webrtc.org/2574943003
Cr-Commit-Position: refs/heads/master@{#15684}
Committed: https://chromium.googlesource.com/external/webrtc/+/efde90838055f44ca05863ba020ca02c88b6d14c

[johan, 2016-12-14 14:17:05]

johan@webrtc.org changed reviewers:
+ sprang@webrtc.org, stefan@webrtc.org

[sprang_webrtc, 2016-12-15 08:58:41]

lgtm

[stefan-webrtc, 2016-12-19 15:32:54]

lgtm

[johan, 2016-12-19 15:33:57]

The CQ bit was checked by johan@webrtc.org

[commit-bot: I haz the power, 2016-12-19 15:34:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[johan, 2016-12-19 15:44:04]

The CQ bit was unchecked by johan@webrtc.org

[johan, 2016-12-19 15:44:13]

Description was changed from

==========
Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.

Name should represent the acual meaning.

BUG=None
==========

to

==========
Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.

Name should represent the actual meaning.

BUG=None
==========

[johan, 2016-12-19 15:44:56]

The CQ bit was checked by johan@webrtc.org

[commit-bot: I haz the power, 2016-12-19 15:45:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[johan, 2016-12-19 15:45:17]

The CQ bit was unchecked by johan@webrtc.org

[johan, 2016-12-19 16:30:36]

The CQ bit was checked by johan@webrtc.org

[commit-bot: I haz the power, 2016-12-19 16:30:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-19 16:32:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482165036427960, "parent_rev":
"1865a15b9a666806647c42033b43bd2c1213b653", "commit_rev":
"efde90838055f44ca05863ba020ca02c88b6d14c"}

[commit-bot: I haz the power, 2016-12-19 16:32:27]

Description was changed from

==========
Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.

Name should represent the actual meaning.

BUG=None
==========

to

==========
Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.

Name should represent the actual meaning.

BUG=None

Review-Url: https://codereview.webrtc.org/2574943003
Cr-Commit-Position: refs/heads/master@{#15684}
Committed:
https://chromium.googlesource.com/external/webrtc/+/efde90838055f44ca05863ba0...
==========

[commit-bot: I haz the power, 2016-12-19 16:32:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/efde90838055f44ca05863ba0...

[danilchap, 2016-12-19 17:36:14]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2589783003/ by danilchap@webrtc.org.

The reason for reverting is: breaks downstream project.

Can you make this change in a compatible way using anonymous union:
union {
  bool is_first_packet_in_frame;
  RTC_DEPRECATED bool isFirstPacket;
};
(unfortunetly this this treak breaks braced initialization in
rtp_rtcp_impl_unittest.cc,
so that should be rewritting in a more classic way).