Rename RTPVideoHeader.isFirstPacket to .is_first_packet_in_frame.

webrtc/modules/video_coding/decoding_state_unittest.cc

 /*
  *  Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 14 matching lines @@
   EXPECT_TRUE(dec_state.in_initial_state());
   EXPECT_TRUE(dec_state.full_sync());
 }
 
 TEST(TestDecodingState, FrameContinuity) {
   VCMDecodingState dec_state;
   // Check that makes decision based on correct method.
   VCMFrameBuffer frame;
   VCMFrameBuffer frame_key;
   VCMPacket packet;
-  packet.isFirstPacket = true;
+  packet.is_first_packet_in_frame = true;
   packet.timestamp = 1;
   packet.seqNum = 0xffff;
   packet.frameType = kVideoFrameDelta;
   packet.video_header.codec = kRtpVideoVp8;
   packet.video_header.codecHeader.VP8.pictureId = 0x007F;
   FrameData frame_data;
   frame_data.rtt_ms = 0;
   frame_data.rolling_average_packets_per_frame = -1;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   // Always start with a key frame.
   dec_state.Reset();
   EXPECT_FALSE(dec_state.ContinuousFrame(&frame));
   packet.frameType = kVideoFrameKey;
   EXPECT_LE(0, frame_key.InsertPacket(packet, 0, kNoErrors, frame_data));
   EXPECT_TRUE(dec_state.ContinuousFrame(&frame_key));
   dec_state.SetState(&frame);
   frame.Reset();
   packet.frameType = kVideoFrameDelta;
   // Use pictureId
-  packet.isFirstPacket = false;
+  packet.is_first_packet_in_frame = false;
   packet.video_header.codecHeader.VP8.pictureId = 0x0002;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   EXPECT_FALSE(dec_state.ContinuousFrame(&frame));
   frame.Reset();
   packet.video_header.codecHeader.VP8.pictureId = 0;
   packet.seqNum = 10;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   EXPECT_TRUE(dec_state.ContinuousFrame(&frame));
 
   // Use sequence numbers.
@@ skipping 187 matching lines @@
   packet.video_header.codecHeader.VP8.temporalIdx = 0;
   packet.video_header.codecHeader.VP8.pictureId = 4;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   EXPECT_TRUE(dec_state.ContinuousFrame(&frame));
   dec_state.SetState(&frame);
   EXPECT_FALSE(dec_state.full_sync());
   // Insert key frame - should update sync value.
   // A key frame is always a base layer.
   frame.Reset();
   packet.frameType = kVideoFrameKey;
-  packet.isFirstPacket = 1;
+  packet.is_first_packet_in_frame = 1;
   packet.timestamp = 5;
   packet.seqNum = 5;
   packet.video_header.codecHeader.VP8.tl0PicIdx = 2;
   packet.video_header.codecHeader.VP8.temporalIdx = 0;
   packet.video_header.codecHeader.VP8.pictureId = 5;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   EXPECT_TRUE(dec_state.ContinuousFrame(&frame));
   dec_state.SetState(&frame);
   EXPECT_TRUE(dec_state.full_sync());
   // After sync, a continuous PictureId is required
   // (continuous base layer is not enough )
   frame.Reset();
   packet.frameType = kVideoFrameDelta;
   packet.timestamp = 6;
   packet.seqNum = 6;
   packet.video_header.codecHeader.VP8.tl0PicIdx = 3;
   packet.video_header.codecHeader.VP8.temporalIdx = 0;
   packet.video_header.codecHeader.VP8.pictureId = 6;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   EXPECT_TRUE(dec_state.ContinuousFrame(&frame));
   EXPECT_TRUE(dec_state.full_sync());
   frame.Reset();
   packet.frameType = kVideoFrameDelta;
-  packet.isFirstPacket = 1;
+  packet.is_first_packet_in_frame = 1;
   packet.timestamp = 8;
   packet.seqNum = 8;
   packet.video_header.codecHeader.VP8.tl0PicIdx = 4;
   packet.video_header.codecHeader.VP8.temporalIdx = 0;
   packet.video_header.codecHeader.VP8.pictureId = 8;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   EXPECT_FALSE(dec_state.ContinuousFrame(&frame));
   EXPECT_TRUE(dec_state.full_sync());
   dec_state.SetState(&frame);
   EXPECT_FALSE(dec_state.full_sync());
 
   // Insert a non-ref frame - should update sync value.
   frame.Reset();
   packet.frameType = kVideoFrameDelta;
-  packet.isFirstPacket = 1;
+  packet.is_first_packet_in_frame = 1;
   packet.timestamp = 9;
   packet.seqNum = 9;
   packet.video_header.codecHeader.VP8.tl0PicIdx = 4;
   packet.video_header.codecHeader.VP8.temporalIdx = 2;
   packet.video_header.codecHeader.VP8.pictureId = 9;
   packet.video_header.codecHeader.VP8.layerSync = true;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   dec_state.SetState(&frame);
   EXPECT_TRUE(dec_state.full_sync());
 
   // The following test will verify the sync flag behavior after a loss.
   // Create the following pattern:
   // Update base layer, lose packet 1 (sync flag on, layer 2), insert packet 3
   // (sync flag on, layer 2) check continuity and sync flag after inserting
   // packet 2 (sync flag on, layer 1).
   // Base layer.
   frame.Reset();
   dec_state.Reset();
   packet.frameType = kVideoFrameDelta;
-  packet.isFirstPacket = 1;
+  packet.is_first_packet_in_frame = 1;
   packet.markerBit = 1;
   packet.timestamp = 0;
   packet.seqNum = 0;
   packet.video_header.codecHeader.VP8.tl0PicIdx = 0;
   packet.video_header.codecHeader.VP8.temporalIdx = 0;
   packet.video_header.codecHeader.VP8.pictureId = 0;
   packet.video_header.codecHeader.VP8.layerSync = false;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   dec_state.SetState(&frame);
   EXPECT_TRUE(dec_state.full_sync());
   // Layer 2 - 2 packets (insert one, lose one).
   frame.Reset();
   packet.frameType = kVideoFrameDelta;
-  packet.isFirstPacket = 1;
+  packet.is_first_packet_in_frame = 1;
   packet.markerBit = 0;
   packet.timestamp = 1;
   packet.seqNum = 1;
   packet.video_header.codecHeader.VP8.tl0PicIdx = 0;
   packet.video_header.codecHeader.VP8.temporalIdx = 2;
   packet.video_header.codecHeader.VP8.pictureId = 1;
   packet.video_header.codecHeader.VP8.layerSync = true;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   EXPECT_TRUE(dec_state.ContinuousFrame(&frame));
   // Layer 1
   frame.Reset();
   packet.frameType = kVideoFrameDelta;
-  packet.isFirstPacket = 1;
+  packet.is_first_packet_in_frame = 1;
   packet.markerBit = 1;
   packet.timestamp = 2;
   packet.seqNum = 3;
   packet.video_header.codecHeader.VP8.tl0PicIdx = 0;
   packet.video_header.codecHeader.VP8.temporalIdx = 1;
   packet.video_header.codecHeader.VP8.pictureId = 2;
   packet.video_header.codecHeader.VP8.layerSync = true;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   EXPECT_FALSE(dec_state.ContinuousFrame(&frame));
   EXPECT_TRUE(dec_state.full_sync());
@@ skipping 83 matching lines @@
   packet.video_header.codecHeader.VP8.temporalIdx++;
   packet.video_header.codecHeader.VP8.tl0PicIdx = 1;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   EXPECT_FALSE(dec_state.ContinuousFrame(&frame));
 }
 
 TEST(TestDecodingState, FrameContinuityFlexibleModeKeyFrame) {
   VCMDecodingState dec_state;
   VCMFrameBuffer frame;
   VCMPacket packet;
-  packet.isFirstPacket = true;
+  packet.is_first_packet_in_frame = true;
   packet.timestamp = 1;
   packet.seqNum = 0xffff;
   uint8_t data[] = "I need a data pointer for this test!";
   packet.sizeBytes = sizeof(data);
   packet.dataPtr = data;
   packet.video_header.codec = kRtpVideoVp9;
 
   RTPVideoHeaderVP9& vp9_hdr = packet.video_header.codecHeader.VP9;
   vp9_hdr.picture_id = 10;
   vp9_hdr.flexible_mode = true;
@@ skipping 22 matching lines @@
   vp9_hdr.num_ref_pics = 1;
   vp9_hdr.pid_diff[0] = 1;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   EXPECT_TRUE(dec_state.ContinuousFrame(&frame));
 }
 
 TEST(TestDecodingState, FrameContinuityFlexibleModeOutOfOrderFrames) {
   VCMDecodingState dec_state;
   VCMFrameBuffer frame;
   VCMPacket packet;
-  packet.isFirstPacket = true;
+  packet.is_first_packet_in_frame = true;
   packet.timestamp = 1;
   packet.seqNum = 0xffff;
   uint8_t data[] = "I need a data pointer for this test!";
   packet.sizeBytes = sizeof(data);
   packet.dataPtr = data;
   packet.video_header.codec = kRtpVideoVp9;
 
   RTPVideoHeaderVP9& vp9_hdr = packet.video_header.codecHeader.VP9;
   vp9_hdr.picture_id = 10;
   vp9_hdr.flexible_mode = true;
@@ skipping 34 matching lines @@
   vp9_hdr.pid_diff[1] = 8;
   vp9_hdr.pid_diff[2] = 5;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   EXPECT_TRUE(dec_state.ContinuousFrame(&frame));
 }
 
 TEST(TestDecodingState, FrameContinuityFlexibleModeGeneral) {
   VCMDecodingState dec_state;
   VCMFrameBuffer frame;
   VCMPacket packet;
-  packet.isFirstPacket = true;
+  packet.is_first_packet_in_frame = true;
   packet.timestamp = 1;
   packet.seqNum = 0xffff;
   uint8_t data[] = "I need a data pointer for this test!";
   packet.sizeBytes = sizeof(data);
   packet.dataPtr = data;
   packet.video_header.codec = kRtpVideoVp9;
 
   RTPVideoHeaderVP9& vp9_hdr = packet.video_header.codecHeader.VP9;
   vp9_hdr.picture_id = 10;
   vp9_hdr.flexible_mode = true;
@@ skipping 128 matching lines @@
   // Ref to frame previous to KF, not continuous
   frame.Reset();
   vp9_hdr.picture_id = 30;
   vp9_hdr.num_ref_pics = 1;
   vp9_hdr.pid_diff[0] = 30;
   EXPECT_LE(0, frame.InsertPacket(packet, 0, kNoErrors, frame_data));
   EXPECT_FALSE(dec_state.ContinuousFrame(&frame));
 }
 
 }  // namespace webrtc