Simplify SetFecParameters signature.

Simplify SetFecParameters signature.

- Change const ptr to const ref in parameter list.
  Using nullptr as argument was invalid, so no need to send
  pointer instead of reference.
- Change return type to void or bool, where appropriate

BUG=webrtc:5654
Committed: https://crrev.com/1743a19183e65c338db05d2b212afd6a13151721
Cr-Commit-Position: refs/heads/master@{#14945}

[brandtr, 2016-10-28 08:15:50]

Description was changed from

==========
Change const ptr to const ref in SetFecParameters signature.

Using nullptr as argument was invalid, so no need to send
pointer instead of reference.

BUG=webrtc:5654
==========

to

==========
Simplify SetFecParameters signature.

- Change const ptr to const ref in parameter list.
  Using nullptr as argument was invalid, so no need to send
  pointer instead of reference.
- Change return type to void or bool, where appropriate

BUG=webrtc:5654
==========

[brandtr, 2016-10-28 08:17:05]

brandtr@webrtc.org changed reviewers:
+ danilchap@webrtc.org, stefan@webrtc.org

[brandtr, 2016-10-28 08:17:06]

Tiny cleanup.

[danilchap, 2016-10-28 10:16:41]

https://codereview.webrtc.org/2455963003/diff/20001/webrtc/modules/rtp_rtcp/i...
File webrtc/modules/rtp_rtcp/include/rtp_rtcp.h (right):

https://codereview.webrtc.org/2455963003/diff/20001/webrtc/modules/rtp_rtcp/i...
webrtc/modules/rtp_rtcp/include/rtp_rtcp.h:464: virtual bool
SetFecParameters(const FecProtectionParams& delta_params,
to avoid breaking dependant projects, keep the old signature too for a while:
RTC_DEPRECATED
inline int32_t SetFecParameters(* delta, *key) {
  return SetFecParameters(*delta, *key) ? 0 : -1;
}

https://codereview.webrtc.org/2455963003/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/include/video_coding_defines.h (right):

https://codereview.webrtc.org/2455963003/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/include/video_coding_defines.h:117: virtual void
ProtectionRequest(const FecProtectionParams& delta_params,
changing this interface will break dependent projects.
change it in backward compatible way (may be in a dedicated CL)

[brandtr, 2016-10-28 10:54:27]

Patchset #3 (id:40001) has been deleted

[brandtr, 2016-10-28 11:06:10]

https://codereview.webrtc.org/2455963003/diff/20001/webrtc/modules/rtp_rtcp/i...
File webrtc/modules/rtp_rtcp/include/rtp_rtcp.h (right):

https://codereview.webrtc.org/2455963003/diff/20001/webrtc/modules/rtp_rtcp/i...
webrtc/modules/rtp_rtcp/include/rtp_rtcp.h:464: virtual bool
SetFecParameters(const FecProtectionParams& delta_params,
On 2016/10/28 10:16:41, danilchap wrote:
> to avoid breaking dependant projects, keep the old signature too for a while:
> RTC_DEPRECATED
> inline int32_t SetFecParameters(* delta, *key) {
>   return SetFecParameters(*delta, *key) ? 0 : -1;
> }

Done.

Added implementation in rtp_rtcp_impl.cc, to avoid having to include checks.h in
this file.

https://codereview.webrtc.org/2455963003/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/include/video_coding_defines.h (right):

https://codereview.webrtc.org/2455963003/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/include/video_coding_defines.h:117: virtual void
ProtectionRequest(const FecProtectionParams& delta_params,
On 2016/10/28 10:16:41, danilchap wrote:
> changing this interface will break dependent projects.
> change it in backward compatible way (may be in a dedicated CL)

I see. I'll leave it unchanged for now.

[danilchap, 2016-10-28 11:16:12]

lgtm % nit

https://codereview.webrtc.org/2455963003/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc (right):

https://codereview.webrtc.org/2455963003/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc:65: inline int32_t
RtpRtcp::SetFecParameters(
since it is in .cc remove inline (you might get linking problems if you inline
it in .cc but use it in a different compilation unit)

[brandtr, 2016-10-28 12:10:03]

https://codereview.webrtc.org/2455963003/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc (right):

https://codereview.webrtc.org/2455963003/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc:65: inline int32_t
RtpRtcp::SetFecParameters(
On 2016/10/28 11:16:11, danilchap wrote:
> since it is in .cc remove inline (you might get linking problems if you inline
> it in .cc but use it in a different compilation unit)

Done.

[stefan-webrtc, 2016-10-31 09:49:11]

lgtm

[brandtr, 2016-10-31 12:05:58]

Rebase.

[brandtr, 2016-10-31 12:53:39]

Rebase.

[brandtr, 2016-11-02 11:06:13]

Rebase.

[brandtr, 2016-11-03 15:33:35]

Rebase.

[brandtr, 2016-11-07 11:16:59]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-11-07 11:16:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
danilchap@webrtc.org, stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2455963003/#ps180001 (title:
"Fix fuzzer.")

[commit-bot: I haz the power, 2016-11-07 11:17:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-07 11:36:08]

Description was changed from

==========
Simplify SetFecParameters signature.

- Change const ptr to const ref in parameter list.
  Using nullptr as argument was invalid, so no need to send
  pointer instead of reference.
- Change return type to void or bool, where appropriate

BUG=webrtc:5654
==========

to

==========
Simplify SetFecParameters signature.

- Change const ptr to const ref in parameter list.
  Using nullptr as argument was invalid, so no need to send
  pointer instead of reference.
- Change return type to void or bool, where appropriate

BUG=webrtc:5654
==========

[commit-bot: I haz the power, 2016-11-07 11:36:10]

Committed patchset #9 (id:180001)

[commit-bot: I haz the power, 2016-11-07 11:36:21]

Description was changed from

==========
Simplify SetFecParameters signature.

- Change const ptr to const ref in parameter list.
  Using nullptr as argument was invalid, so no need to send
  pointer instead of reference.
- Change return type to void or bool, where appropriate

BUG=webrtc:5654
==========

to

==========
Simplify SetFecParameters signature.

- Change const ptr to const ref in parameter list.
  Using nullptr as argument was invalid, so no need to send
  pointer instead of reference.
- Change return type to void or bool, where appropriate

BUG=webrtc:5654

Committed: https://crrev.com/1743a19183e65c338db05d2b212afd6a13151721
Cr-Commit-Position: refs/heads/master@{#14945}
==========

[commit-bot: I haz the power, 2016-11-07 11:36:22]

Patchset 9 (id:??) landed as
https://crrev.com/1743a19183e65c338db05d2b212afd6a13151721
Cr-Commit-Position: refs/heads/master@{#14945}