Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: webrtc/modules/video_coding/include/video_coding_defines.h

Issue 2455963003: Simplify SetFecParameters signature. (Closed)
Patch Set: Return type int32_t replaced by bool and void. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 int render_delay_ms) = 0; 107 int render_delay_ms) = 0;
108 108
109 protected: 109 protected:
110 virtual ~VCMDecoderTimingCallback() {} 110 virtual ~VCMDecoderTimingCallback() {}
111 }; 111 };
112 112
113 // Callback class used for telling the user about how to configure the FEC, 113 // Callback class used for telling the user about how to configure the FEC,
114 // and the rates sent the last second is returned to the VCM. 114 // and the rates sent the last second is returned to the VCM.
115 class VCMProtectionCallback { 115 class VCMProtectionCallback {
116 public: 116 public:
117 virtual int ProtectionRequest(const FecProtectionParams* delta_params, 117 virtual void ProtectionRequest(const FecProtectionParams& delta_params,
danilchap 2016/10/28 10:16:41 changing this interface will break dependent proje
brandtr 2016/10/28 11:06:10 I see. I'll leave it unchanged for now.
118 const FecProtectionParams* key_params, 118 const FecProtectionParams& key_params,
119 uint32_t* sent_video_rate_bps, 119 uint32_t* sent_video_rate_bps,
120 uint32_t* sent_nack_rate_bps, 120 uint32_t* sent_nack_rate_bps,
121 uint32_t* sent_fec_rate_bps) = 0; 121 uint32_t* sent_fec_rate_bps) = 0;
122 122
123 protected: 123 protected:
124 virtual ~VCMProtectionCallback() {} 124 virtual ~VCMProtectionCallback() {}
125 }; 125 };
126 126
127 // Callback class used for telling the user about what frame type needed to 127 // Callback class used for telling the user about what frame type needed to
128 // continue decoding. 128 // continue decoding.
129 // Typically a key frame when the stream has been corrupted in some way. 129 // Typically a key frame when the stream has been corrupted in some way.
130 class VCMFrameTypeCallback { 130 class VCMFrameTypeCallback {
131 public: 131 public:
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 public: 164 public:
165 virtual void RequestKeyFrame() = 0; 165 virtual void RequestKeyFrame() = 0;
166 166
167 protected: 167 protected:
168 virtual ~KeyFrameRequestSender() {} 168 virtual ~KeyFrameRequestSender() {}
169 }; 169 };
170 170
171 } // namespace webrtc 171 } // namespace webrtc
172 172
173 #endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_DEFINES_H_ 173 #endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_DEFINES_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698