Chromium Code Reviews

Unified Diff: webrtc/modules/rtp_rtcp/source/ulpfec_generator.cc

Issue 2455963003: Simplify SetFecParameters signature. (Closed)
Patch Set: Fix fuzzer. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: webrtc/modules/rtp_rtcp/source/ulpfec_generator.cc
diff --git a/webrtc/modules/rtp_rtcp/source/ulpfec_generator.cc b/webrtc/modules/rtp_rtcp/source/ulpfec_generator.cc
index c9de401d7103d15f1cd06454e7728bdbe12b0586..4c50e222910cd3a061c51704171f6d7c09bdc46e 100644
--- a/webrtc/modules/rtp_rtcp/source/ulpfec_generator.cc
+++ b/webrtc/modules/rtp_rtcp/source/ulpfec_generator.cc
@@ -120,13 +120,13 @@ std::unique_ptr<RedPacket> UlpfecGenerator::BuildRedPacket(
return red_packet;
}
-void UlpfecGenerator::SetFecParameters(const FecProtectionParams* params) {
- RTC_DCHECK_GE(params->fec_rate, 0);
- RTC_DCHECK_LE(params->fec_rate, 255);
+void UlpfecGenerator::SetFecParameters(const FecProtectionParams& params) {
+ RTC_DCHECK_GE(params.fec_rate, 0);
+ RTC_DCHECK_LE(params.fec_rate, 255);
// Store the new params and apply them for the next set of FEC packets being
// produced.
- new_params_ = *params;
- if (params->fec_rate > kHighProtectionThreshold) {
+ new_params_ = params;
+ if (params.fec_rate > kHighProtectionThreshold) {
min_num_media_packets_ = kMinMediaPackets;
} else {
min_num_media_packets_ = 1;
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/ulpfec_generator.h ('k') | webrtc/modules/rtp_rtcp/source/ulpfec_generator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine