Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 2455963003: Simplify SetFecParameters signature. (Closed)
Patch Set: Fix fuzzer. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_ 11 #ifndef WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
12 #define WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_ 12 #define WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
13 13
14 #include <set> 14 #include <set>
15 #include <string> 15 #include <string>
16 #include <utility> 16 #include <utility>
17 #include <vector> 17 #include <vector>
18 18
19 #include "webrtc/base/constructormagic.h" 19 #include "webrtc/base/constructormagic.h"
20 #include "webrtc/base/deprecation.h"
20 #include "webrtc/modules/include/module.h" 21 #include "webrtc/modules/include/module.h"
21 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h" 22 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
22 #include "webrtc/modules/video_coding/include/video_coding_defines.h" 23 #include "webrtc/modules/video_coding/include/video_coding_defines.h"
23 24
24 namespace webrtc { 25 namespace webrtc {
25 26
26 // Forward declarations. 27 // Forward declarations.
27 class RateLimiter; 28 class RateLimiter;
28 class ReceiveStatistics; 29 class ReceiveStatistics;
29 class RemoteBitrateEstimator; 30 class RemoteBitrateEstimator;
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 // ULPFEC without enabling RED. However, we DO support enabling RED without 459 // ULPFEC without enabling RED. However, we DO support enabling RED without
459 // enabling ULPFEC. This is due to an RED/RTX workaround, where the receiver 460 // enabling ULPFEC. This is due to an RED/RTX workaround, where the receiver
460 // assumes that RTX packets carry RED if RED has been configured in the SDP, 461 // assumes that RTX packets carry RED if RED has been configured in the SDP,
461 // regardless of what RTX payload type mapping was negotiated in the SDP. 462 // regardless of what RTX payload type mapping was negotiated in the SDP.
462 // TODO(brandtr): Update this comment when we have removed the RED/RTX 463 // TODO(brandtr): Update this comment when we have removed the RED/RTX
463 // send-side workaround, i.e., when we do not support enabling RED without 464 // send-side workaround, i.e., when we do not support enabling RED without
464 // enabling ULPFEC. 465 // enabling ULPFEC.
465 virtual void SetUlpfecConfig(int red_payload_type, 466 virtual void SetUlpfecConfig(int red_payload_type,
466 int ulpfec_payload_type) = 0; 467 int ulpfec_payload_type) = 0;
467 468
468 virtual int32_t SetFecParameters(const FecProtectionParams* delta_params, 469 // Set FEC rates, max frames before FEC is sent, and type of FEC masks.
469 const FecProtectionParams* key_params) = 0; 470 // Returns false on failure.
471 virtual bool SetFecParameters(const FecProtectionParams& delta_params,
472 const FecProtectionParams& key_params) = 0;
473
474 // Deprecated version of member function above.
475 RTC_DEPRECATED
476 int32_t SetFecParameters(const FecProtectionParams* delta_params,
477 const FecProtectionParams* key_params);
470 478
471 // Set method for requestion a new key frame. 479 // Set method for requestion a new key frame.
472 // Returns -1 on failure else 0. 480 // Returns -1 on failure else 0.
473 virtual int32_t SetKeyFrameRequestMethod(KeyFrameRequestMethod method) = 0; 481 virtual int32_t SetKeyFrameRequestMethod(KeyFrameRequestMethod method) = 0;
474 482
475 // Sends a request for a keyframe. 483 // Sends a request for a keyframe.
476 // Returns -1 on failure else 0. 484 // Returns -1 on failure else 0.
477 virtual int32_t RequestKeyFrame() = 0; 485 virtual int32_t RequestKeyFrame() = 0;
478 }; 486 };
479 487
480 } // namespace webrtc 488 } // namespace webrtc
481 489
482 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_ 490 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698