Simplify SetFecParameters signature.

webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 441 matching lines @@
   // **************************************************************************
   // Video
   // **************************************************************************
 
   // Set RED and ULPFEC payload types. A payload type of -1
   // means that the corresponding feature is turned off.
   // That is, RED and ULPFEC can be enabled/disabled individually.
   virtual void SetUlpfecConfig(int red_payload_type,
                                int ulpfec_payload_type) = 0;
 
-  virtual int32_t SetFecParameters(const FecProtectionParams* delta_params,
-                                   const FecProtectionParams* key_params) = 0;
+  // Set FEC rates, max frames before FEC is sent, and type of FEC masks.
+  // Returns false on failure.
+  virtual bool SetFecParameters(const FecProtectionParams& delta_params,

[danilchap, 2016/10/28 10:16:41]

to avoid breaking dependant projects, keep the old signature too for a while:
RTC_DEPRECATED
inline int32_t SetFecParameters(* delta, *key) {
  return SetFecParameters(*delta, *key) ? 0 : -1;
}

[brandtr, 2016/10/28 11:06:10]

Done.

Added implementation in rtp_rtcp_impl.cc, to avoid having to include checks.h in
this file.

+                                const FecProtectionParams& key_params) = 0;
 
   // Set method for requestion a new key frame.
   // Returns -1 on failure else 0.
   virtual int32_t SetKeyFrameRequestMethod(KeyFrameRequestMethod method) = 0;
 
   // Sends a request for a keyframe.
   // Returns -1 on failure else 0.
   virtual int32_t RequestKeyFrame() = 0;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_