rtc_stats: Update code to remove chromium style warnings suppression.

rtc_stats: Update code to remove chromium style warnings suppression.

The warning previously suppressed made it possible to define tings like
constructors in the header, and "complex" objects did not need to have
an explicit out-of-line copy constructor, destructor, etc.

To be able to not suppress this warning, the RTCStats macro was split
into a WEBRTC_RTCSTATS_DECL() and WEBRTC_RTCSTATS_IMPL() for .h and .cc
respectively. Some copy constructors are also defined.

BUG=chromium:627816
Committed: https://crrev.com/fc5e0504ea0dd341046779881908d4640617a2f0
Cr-Commit-Position: refs/heads/master@{#14545}

[hbos, 2016-09-26 14:17:59]

hbos@webrtc.org changed reviewers:
+ hta@webrtc.org

[hbos, 2016-09-26 14:17:59]

Please take a look, hta.

[hbos, 2016-09-29 12:21:21]

Ping hta

[hta-webrtc, 2016-10-04 13:51:05]

lgtm

comment nits, as usual.

https://codereview.webrtc.org/2373503002/diff/40001/webrtc/api/stats/rtcstats.h
File webrtc/api/stats/rtcstats.h (right):

https://codereview.webrtc.org/2373503002/diff/40001/webrtc/api/stats/rtcstats...
webrtc/api/stats/rtcstats.h:98: // The macro declares and defines the static
|kType| and overrides methods as
More precise:

These macros declare (in _DECL) and define (in _IMPL) the static |kType|....

https://codereview.webrtc.org/2373503002/diff/40001/webrtc/api/stats/rtcstats...
webrtc/api/stats/rtcstats.h:102: // have at least one new member).
Suggest replacing parenthesis with "The list must have at least one member".

At this level of explanation, the concept of new vs old members doesn't exist.

[hbos, 2016-10-06 08:38:57]

https://codereview.webrtc.org/2373503002/diff/40001/webrtc/api/stats/rtcstats.h
File webrtc/api/stats/rtcstats.h (right):

https://codereview.webrtc.org/2373503002/diff/40001/webrtc/api/stats/rtcstats...
webrtc/api/stats/rtcstats.h:98: // The macro declares and defines the static
|kType| and overrides methods as
On 2016/10/04 13:51:04, hta-webrtc wrote:
> More precise:
> 
> These macros declare (in _DECL) and define (in _IMPL) the static |kType|....

Done.

https://codereview.webrtc.org/2373503002/diff/40001/webrtc/api/stats/rtcstats...
webrtc/api/stats/rtcstats.h:102: // have at least one new member).
On 2016/10/04 13:51:04, hta-webrtc wrote:
> Suggest replacing parenthesis with "The list must have at least one member".
> 
> At this level of explanation, the concept of new vs old members doesn't exist.

Done.

[hbos, 2016-10-06 08:39:00]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-10-06 08:39:01]

The patchset sent to the CQ was uploaded after l-g-t-m from hta@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2373503002/#ps60001 (title:
"Addressed comments and rebase with master")

[commit-bot: I haz the power, 2016-10-06 08:39:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-06 09:06:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-06 09:06:18]

Description was changed from

==========
rtc_stats: Update code to remove chromium style warnings suppression.

The warning previously suppressed made it possible to define tings like
constructors in the header, and "complex" objects did not need to have
an explicit out-of-line copy constructor, destructor, etc.

To be able to not suppress this warning, the RTCStats macro was split
into a WEBRTC_RTCSTATS_DECL() and WEBRTC_RTCSTATS_IMPL() for .h and .cc
respectively. Some copy constructors are also defined.

BUG=chromium:627816
==========

to

==========
rtc_stats: Update code to remove chromium style warnings suppression.

The warning previously suppressed made it possible to define tings like
constructors in the header, and "complex" objects did not need to have
an explicit out-of-line copy constructor, destructor, etc.

To be able to not suppress this warning, the RTCStats macro was split
into a WEBRTC_RTCSTATS_DECL() and WEBRTC_RTCSTATS_IMPL() for .h and .cc
respectively. Some copy constructors are also defined.

BUG=chromium:627816

Committed: https://crrev.com/fc5e0504ea0dd341046779881908d4640617a2f0
Cr-Commit-Position: refs/heads/master@{#14545}
==========

[commit-bot: I haz the power, 2016-10-06 09:06:19]

Patchset 4 (id:??) landed as
https://crrev.com/fc5e0504ea0dd341046779881908d4640617a2f0
Cr-Commit-Position: refs/heads/master@{#14545}