Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Side by Side Diff: webrtc/stats/BUILD.gn

Issue 2373503002: rtc_stats: Update code to remove chromium style warnings suppression. (Closed)
Patch Set: Addressed comments and rebase with master Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/stats/rtcstats_objects.h ('k') | webrtc/stats/rtcstats_objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../build/webrtc.gni") 9 import("../build/webrtc.gni")
10 10
11 group("stats") { 11 group("stats") {
12 public_deps = [ 12 public_deps = [
13 ":rtc_stats", 13 ":rtc_stats",
14 ] 14 ]
15 } 15 }
16 16
17 # GYP version: webrtc/stats/stats.gyp:rtc_stats 17 # GYP version: webrtc/stats/stats.gyp:rtc_stats
18 rtc_static_library("rtc_stats") { 18 rtc_static_library("rtc_stats") {
19 cflags = [] 19 cflags = []
20 sources = [ 20 sources = [
21 "rtcstats.cc", 21 "rtcstats.cc",
22 "rtcstats_objects.cc", 22 "rtcstats_objects.cc",
23 "rtcstatsreport.cc", 23 "rtcstatsreport.cc",
24 ] 24 ]
25 25
26 if (is_clang) {
27 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
28 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
29 }
30
31 deps = [ 26 deps = [
32 "../api:rtc_stats_api", 27 "../api:rtc_stats_api",
33 "../base:rtc_base_approved", 28 "../base:rtc_base_approved",
34 ] 29 ]
35 } 30 }
36 31
37 rtc_source_set("rtc_stats_test_utils") { 32 rtc_source_set("rtc_stats_test_utils") {
38 cflags = [] 33 cflags = []
39 sources = [ 34 sources = [
40 "test/rtcteststats.cc", 35 "test/rtcteststats.cc",
41 "test/rtcteststats.h", 36 "test/rtcteststats.h",
42 ] 37 ]
43 38
44 if (is_clang) {
45 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
46 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
47 }
48
49 deps = [ 39 deps = [
50 ":rtc_stats", 40 ":rtc_stats",
51 "../api:rtc_stats_api", 41 "../api:rtc_stats_api",
52 ] 42 ]
53 } 43 }
54 44
55 if (rtc_include_tests) { 45 if (rtc_include_tests) {
56 rtc_test("rtc_stats_unittests") { 46 rtc_test("rtc_stats_unittests") {
57 testonly = true 47 testonly = true
58 sources = [ 48 sources = [
(...skipping 12 matching lines...) Expand all
71 "../base:rtc_base_tests_utils", 61 "../base:rtc_base_tests_utils",
72 "../system_wrappers:metrics_default", 62 "../system_wrappers:metrics_default",
73 "//testing/gmock", 63 "//testing/gmock",
74 ] 64 ]
75 65
76 if (is_android) { 66 if (is_android) {
77 deps += [ "//testing/android/native_test:native_test_native_code" ] 67 deps += [ "//testing/android/native_test:native_test_native_code" ]
78 } 68 }
79 } 69 }
80 } 70 }
OLDNEW
« no previous file with comments | « webrtc/api/stats/rtcstats_objects.h ('k') | webrtc/stats/rtcstats_objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698