Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: webrtc/stats/rtcstats_unittest.cc

Issue 2373503002: rtc_stats: Update code to remove chromium style warnings suppression. (Closed)
Patch Set: Addressed comments and rebase with master Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/stats/rtcstats_objects.cc ('k') | webrtc/stats/rtcstatsreport_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/stats/rtcstats_unittest.cc
diff --git a/webrtc/stats/rtcstats_unittest.cc b/webrtc/stats/rtcstats_unittest.cc
index 88a2e03472108b16ba8c65c2e8ef3a033093eac8..ad839d811dbbfe747f80c9b60daf4eb08fa95352 100644
--- a/webrtc/stats/rtcstats_unittest.cc
+++ b/webrtc/stats/rtcstats_unittest.cc
@@ -20,31 +20,31 @@ namespace webrtc {
class RTCChildStats : public RTCStats {
public:
+ WEBRTC_RTCSTATS_DECL();
+
RTCChildStats(const std::string& id, int64_t timestamp_us)
: RTCStats(id, timestamp_us),
child_int("childInt") {}
- WEBRTC_RTCSTATS_IMPL(RTCStats, RTCChildStats,
- &child_int);
-
RTCStatsMember<int32_t> child_int;
};
-const char RTCChildStats::kType[] = "child-stats";
+WEBRTC_RTCSTATS_IMPL(RTCChildStats, RTCStats, "child-stats",
+ &child_int);
class RTCGrandChildStats : public RTCChildStats {
public:
+ WEBRTC_RTCSTATS_DECL();
+
RTCGrandChildStats(const std::string& id, int64_t timestamp_us)
: RTCChildStats(id, timestamp_us),
grandchild_int("grandchildInt") {}
- WEBRTC_RTCSTATS_IMPL(RTCChildStats, RTCGrandChildStats,
- &grandchild_int);
-
RTCStatsMember<int32_t> grandchild_int;
};
-const char RTCGrandChildStats::kType[] = "grandchild-stats";
+WEBRTC_RTCSTATS_IMPL(RTCGrandChildStats, RTCChildStats, "grandchild-stats",
+ &grandchild_int);
TEST(RTCStatsTest, RTCStatsAndMembers) {
RTCTestStats stats("testId", 42);
« no previous file with comments | « webrtc/stats/rtcstats_objects.cc ('k') | webrtc/stats/rtcstatsreport_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698