Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Side by Side Diff: webrtc/api/stats/rtcstats_objects.h

Issue 2373503002: rtc_stats: Update code to remove chromium style warnings suppression. (Closed)
Patch Set: Addressed comments and rebase with master Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/stats/rtcstats.h ('k') | webrtc/stats/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_ 11 #ifndef WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_
12 #define WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_ 12 #define WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_
13 13
14 #include <string> 14 #include <string>
15 15
16 #include "webrtc/api/stats/rtcstats.h" 16 #include "webrtc/api/stats/rtcstats.h"
17 17
18 namespace webrtc { 18 namespace webrtc {
19 19
20 // https://w3c.github.io/webrtc-stats/#certificatestats-dict* 20 // https://w3c.github.io/webrtc-stats/#certificatestats-dict*
21 class RTCCertificateStats : public RTCStats { 21 class RTCCertificateStats : public RTCStats {
22 public: 22 public:
23 WEBRTC_RTCSTATS_DECL();
24
23 RTCCertificateStats(const std::string& id, int64_t timestamp_us); 25 RTCCertificateStats(const std::string& id, int64_t timestamp_us);
24 RTCCertificateStats(std::string&& id, int64_t timestamp_us); 26 RTCCertificateStats(std::string&& id, int64_t timestamp_us);
25 27 RTCCertificateStats(const RTCCertificateStats& other);
26 WEBRTC_RTCSTATS_IMPL(RTCStats, RTCCertificateStats, 28 ~RTCCertificateStats() override;
27 &fingerprint,
28 &fingerprint_algorithm,
29 &base64_certificate,
30 &issuer_certificate_id);
31 29
32 RTCStatsMember<std::string> fingerprint; 30 RTCStatsMember<std::string> fingerprint;
33 RTCStatsMember<std::string> fingerprint_algorithm; 31 RTCStatsMember<std::string> fingerprint_algorithm;
34 RTCStatsMember<std::string> base64_certificate; 32 RTCStatsMember<std::string> base64_certificate;
35 RTCStatsMember<std::string> issuer_certificate_id; 33 RTCStatsMember<std::string> issuer_certificate_id;
36 }; 34 };
37 35
38 // https://w3c.github.io/webrtc-stats/#pcstats-dict* 36 // https://w3c.github.io/webrtc-stats/#pcstats-dict*
39 // TODO(hbos): Tracking bug crbug.com/636818 37 // TODO(hbos): Tracking bug crbug.com/636818
40 class RTCPeerConnectionStats : public RTCStats { 38 class RTCPeerConnectionStats : public RTCStats {
41 public: 39 public:
40 WEBRTC_RTCSTATS_DECL();
41
42 RTCPeerConnectionStats(const std::string& id, int64_t timestamp_us); 42 RTCPeerConnectionStats(const std::string& id, int64_t timestamp_us);
43 RTCPeerConnectionStats(std::string&& id, int64_t timestamp_us); 43 RTCPeerConnectionStats(std::string&& id, int64_t timestamp_us);
44 44 RTCPeerConnectionStats(const RTCPeerConnectionStats& other);
45 WEBRTC_RTCSTATS_IMPL(RTCStats, RTCPeerConnectionStats, 45 ~RTCPeerConnectionStats() override;
46 &data_channels_opened,
47 &data_channels_closed);
48 46
49 RTCStatsMember<uint32_t> data_channels_opened; 47 RTCStatsMember<uint32_t> data_channels_opened;
50 RTCStatsMember<uint32_t> data_channels_closed; 48 RTCStatsMember<uint32_t> data_channels_closed;
51 }; 49 };
52 50
53 } // namespace webrtc 51 } // namespace webrtc
54 52
55 #endif // WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_ 53 #endif // WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_
OLDNEW
« no previous file with comments | « webrtc/api/stats/rtcstats.h ('k') | webrtc/stats/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698