Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: webrtc/stats/rtcstats_objects.cc

Issue 2373503002: rtc_stats: Update code to remove chromium style warnings suppression. (Closed)
Patch Set: Addressed comments and rebase with master Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/stats/BUILD.gn ('k') | webrtc/stats/rtcstats_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/api/stats/rtcstats_objects.h" 11 #include "webrtc/api/stats/rtcstats_objects.h"
12 12
13 namespace webrtc { 13 namespace webrtc {
14 14
15 const char RTCCertificateStats::kType[] = "certificate"; 15 WEBRTC_RTCSTATS_IMPL(RTCCertificateStats, RTCStats, "certificate",
16 &fingerprint,
17 &fingerprint_algorithm,
18 &base64_certificate,
19 &issuer_certificate_id);
16 20
17 RTCCertificateStats::RTCCertificateStats( 21 RTCCertificateStats::RTCCertificateStats(
18 const std::string& id, int64_t timestamp_us) 22 const std::string& id, int64_t timestamp_us)
19 : RTCCertificateStats(std::string(id), timestamp_us) { 23 : RTCCertificateStats(std::string(id), timestamp_us) {
20 } 24 }
21 25
22 RTCCertificateStats::RTCCertificateStats( 26 RTCCertificateStats::RTCCertificateStats(
23 std::string&& id, int64_t timestamp_us) 27 std::string&& id, int64_t timestamp_us)
24 : RTCStats(std::move(id), timestamp_us), 28 : RTCStats(std::move(id), timestamp_us),
25 fingerprint("fingerprint"), 29 fingerprint("fingerprint"),
26 fingerprint_algorithm("fingerprintAlgorithm"), 30 fingerprint_algorithm("fingerprintAlgorithm"),
27 base64_certificate("base64Certificate"), 31 base64_certificate("base64Certificate"),
28 issuer_certificate_id("issuerCertificateId") { 32 issuer_certificate_id("issuerCertificateId") {
29 } 33 }
30 34
31 const char RTCPeerConnectionStats::kType[] = "peer-connection"; 35 RTCCertificateStats::RTCCertificateStats(
36 const RTCCertificateStats& other)
37 : RTCStats(other.id(), other.timestamp_us()),
38 fingerprint(other.fingerprint),
39 fingerprint_algorithm(other.fingerprint_algorithm),
40 base64_certificate(other.base64_certificate),
41 issuer_certificate_id(other.issuer_certificate_id) {
42 }
43
44 RTCCertificateStats::~RTCCertificateStats() {
45 }
46
47 WEBRTC_RTCSTATS_IMPL(RTCPeerConnectionStats, RTCStats, "peer-connection",
48 &data_channels_opened,
49 &data_channels_closed);
32 50
33 RTCPeerConnectionStats::RTCPeerConnectionStats( 51 RTCPeerConnectionStats::RTCPeerConnectionStats(
34 const std::string& id, int64_t timestamp_us) 52 const std::string& id, int64_t timestamp_us)
35 : RTCPeerConnectionStats(std::string(id), timestamp_us) { 53 : RTCPeerConnectionStats(std::string(id), timestamp_us) {
36 } 54 }
37 55
38 RTCPeerConnectionStats::RTCPeerConnectionStats( 56 RTCPeerConnectionStats::RTCPeerConnectionStats(
39 std::string&& id, int64_t timestamp_us) 57 std::string&& id, int64_t timestamp_us)
40 : RTCStats(std::move(id), timestamp_us), 58 : RTCStats(std::move(id), timestamp_us),
41 data_channels_opened("dataChannelsOpened"), 59 data_channels_opened("dataChannelsOpened"),
42 data_channels_closed("dataChannelsClosed") { 60 data_channels_closed("dataChannelsClosed") {
43 } 61 }
44 62
63 RTCPeerConnectionStats::RTCPeerConnectionStats(
64 const RTCPeerConnectionStats& other)
65 : RTCStats(other.id(), other.timestamp_us()),
66 data_channels_opened(other.data_channels_opened),
67 data_channels_closed(other.data_channels_closed) {
68 }
69
70 RTCPeerConnectionStats::~RTCPeerConnectionStats() {
71 }
72
45 } // namespace webrtc 73 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/stats/BUILD.gn ('k') | webrtc/stats/rtcstats_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698