Make 'webrtc' a static library.

Make 'webrtc' a static library.

Most other targets were converted to static_library to match the
GYP build in https://codereview.webrtc.org/2361623004.

The monolithic 'webrtc' wasn't converted due to a limitation in
libtool on Mac: it will fail if there are no object files to link
(see http://crbug.com/625874).
Because of that, a no_op_function.cc source file was added to
the sources here, even if it's not used. This will be further
refactored in the future as part of the Slim and Modular
effort (bugs.webrtc.org/5716).

BUG=webrtc:6418, webrtc:6410
NOTRY=True

Committed: https://crrev.com/ee99696592ecc147af74243dcf1709a39ca7f744
Cr-Commit-Position: refs/heads/master@{#14403}

[kjellander_webrtc, 2016-09-27 06:52:58]

Description was changed from

==========
Make 'webrtc' a static library.

Due to a limitation in libtool on Mac, it is not possible to
have a static_library with no objects (see http://crbug.com/625874).
Because of that, config.cc was added to the sources, even if it's
already in webrtc_common. This will be further refactored in the
future as part of the Slim and Modular effort (bugs.webrtc.org/5716).

BUG=webrtc:6418, webrtc:6410
NOTRY=True
==========

to

==========
Make 'webrtc' a static library.

Most other targets were converted to static_library to match the
GYP build in https://codereview.webrtc.org/2361623004.

The monolithic 'webrtc' wasn't converted due to a limitation in
libtool on Mac: it will fail if there are no object files to link
(see http://crbug.com/625874).
Because of that, config.cc was added to the sources here, even if it's
already in webrtc_common. This will be further refactored in the
future as part of the Slim and Modular effort (bugs.webrtc.org/5716).

BUG=webrtc:6418, webrtc:6410
NOTRY=True
==========

[kjellander_webrtc, 2016-09-27 06:52:58]

kjellander@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[kjellander_webrtc, 2016-09-27 10:34:35]

Patchset #2 (id:20001) has been deleted

[kjellander_webrtc, 2016-09-27 11:55:38]

Patchset #2 (id:40001) has been deleted

[kjellander_webrtc, 2016-09-27 12:22:38]

Assuming win is happy, should we go with this?

[the sun, 2016-09-27 12:59:46]

https://codereview.webrtc.org/2372983002/diff/60001/webrtc/build/no_op_functi...
File webrtc/build/no_op_function.cc (right):

https://codereview.webrtc.org/2372983002/diff/60001/webrtc/build/no_op_functi...
webrtc/build/no_op_function.cc:13: int foobarbaz() {
put it in namespace webrtc {

[kjellander_webrtc, 2016-09-27 13:06:47]

PTAL

https://codereview.webrtc.org/2372983002/diff/60001/webrtc/build/no_op_functi...
File webrtc/build/no_op_function.cc (right):

https://codereview.webrtc.org/2372983002/diff/60001/webrtc/build/no_op_functi...
webrtc/build/no_op_function.cc:13: int foobarbaz() {
On 2016/09/27 12:59:45, the sun wrote:
> put it in namespace webrtc {

Done.

[the sun, 2016-09-27 13:25:23]

lgtm

It's not pretty, but if the workaround unblocks downstream and allows us to move
on with the gyp deprecation, let's do it and revisit as part of slim webrtc.

Two things:
1. CL description talks about config.cc
2. TODOs in no_op_function.cc (and BUILD.gn) would be good.

https://codereview.webrtc.org/2372983002/diff/80001/webrtc/build/no_op_functi...
File webrtc/build/no_op_function.cc (right):

https://codereview.webrtc.org/2372983002/diff/80001/webrtc/build/no_op_functi...
webrtc/build/no_op_function.cc:13: // No-op function that can be used to compile
an object necessary
A blazing TODO would be good here

[kjellander_webrtc, 2016-09-27 18:37:43]

Description was changed from

==========
Make 'webrtc' a static library.

Most other targets were converted to static_library to match the
GYP build in https://codereview.webrtc.org/2361623004.

The monolithic 'webrtc' wasn't converted due to a limitation in
libtool on Mac: it will fail if there are no object files to link
(see http://crbug.com/625874).
Because of that, config.cc was added to the sources here, even if it's
already in webrtc_common. This will be further refactored in the
future as part of the Slim and Modular effort (bugs.webrtc.org/5716).

BUG=webrtc:6418, webrtc:6410
NOTRY=True
==========

to

==========
Make 'webrtc' a static library.

Most other targets were converted to static_library to match the
GYP build in https://codereview.webrtc.org/2361623004.

The monolithic 'webrtc' wasn't converted due to a limitation in
libtool on Mac: it will fail if there are no object files to link
(see http://crbug.com/625874).
Because of that, a no_op_function.cc source file was added to
the sources here, even if it's not used. This will be further
refactored in the future as part of the Slim and Modular
effort (bugs.webrtc.org/5716).

BUG=webrtc:6418, webrtc:6410
NOTRY=True
==========

[kjellander_webrtc, 2016-09-27 18:38:14]

On 2016/09/27 13:25:23, the sun wrote:
> lgtm
> 
> It's not pretty, but if the workaround unblocks downstream and allows us to
move
> on with the gyp deprecation, let's do it and revisit as part of slim webrtc.

Yeah, this might be my ugliest CL in a long time :)

> 
> Two things:
> 1. CL description talks about config.cc
Done

> 2. TODOs in no_op_function.cc (and BUILD.gn) would be good.
Done.

> 
>
https://codereview.webrtc.org/2372983002/diff/80001/webrtc/build/no_op_functi...
> File webrtc/build/no_op_function.cc (right):
> 
>
https://codereview.webrtc.org/2372983002/diff/80001/webrtc/build/no_op_functi...
> webrtc/build/no_op_function.cc:13: // No-op function that can be used to
compile
> an object necessary
> A blazing TODO would be good here

[kjellander_webrtc, 2016-09-27 19:03:28]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2016-09-27 19:03:29]

The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2372983002/#ps100001 (title:
"Added TODOs")

[commit-bot: I haz the power, 2016-09-27 19:03:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-27 19:13:17]

Description was changed from

==========
Make 'webrtc' a static library.

Most other targets were converted to static_library to match the
GYP build in https://codereview.webrtc.org/2361623004.

The monolithic 'webrtc' wasn't converted due to a limitation in
libtool on Mac: it will fail if there are no object files to link
(see http://crbug.com/625874).
Because of that, a no_op_function.cc source file was added to
the sources here, even if it's not used. This will be further
refactored in the future as part of the Slim and Modular
effort (bugs.webrtc.org/5716).

BUG=webrtc:6418, webrtc:6410
NOTRY=True
==========

to

==========
Make 'webrtc' a static library.

Most other targets were converted to static_library to match the
GYP build in https://codereview.webrtc.org/2361623004.

The monolithic 'webrtc' wasn't converted due to a limitation in
libtool on Mac: it will fail if there are no object files to link
(see http://crbug.com/625874).
Because of that, a no_op_function.cc source file was added to
the sources here, even if it's not used. This will be further
refactored in the future as part of the Slim and Modular
effort (bugs.webrtc.org/5716).

BUG=webrtc:6418, webrtc:6410
NOTRY=True
==========

[commit-bot: I haz the power, 2016-09-27 19:13:17]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-09-27 19:13:24]

Description was changed from

==========
Make 'webrtc' a static library.

Most other targets were converted to static_library to match the
GYP build in https://codereview.webrtc.org/2361623004.

The monolithic 'webrtc' wasn't converted due to a limitation in
libtool on Mac: it will fail if there are no object files to link
(see http://crbug.com/625874).
Because of that, a no_op_function.cc source file was added to
the sources here, even if it's not used. This will be further
refactored in the future as part of the Slim and Modular
effort (bugs.webrtc.org/5716).

BUG=webrtc:6418, webrtc:6410
NOTRY=True
==========

to

==========
Make 'webrtc' a static library.

Most other targets were converted to static_library to match the
GYP build in https://codereview.webrtc.org/2361623004.

The monolithic 'webrtc' wasn't converted due to a limitation in
libtool on Mac: it will fail if there are no object files to link
(see http://crbug.com/625874).
Because of that, a no_op_function.cc source file was added to
the sources here, even if it's not used. This will be further
refactored in the future as part of the Slim and Modular
effort (bugs.webrtc.org/5716).

BUG=webrtc:6418, webrtc:6410
NOTRY=True

Committed: https://crrev.com/ee99696592ecc147af74243dcf1709a39ca7f744
Cr-Commit-Position: refs/heads/master@{#14403}
==========

[commit-bot: I haz the power, 2016-09-27 19:13:25]

Patchset 4 (id:??) landed as
https://crrev.com/ee99696592ecc147af74243dcf1709a39ca7f744
Cr-Commit-Position: refs/heads/master@{#14403}