GN: Change rtc_source_set targets --> rtc_static_library

GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported in the libjingle_peerconnection.a file, which
are used by some downstream projects).

After doing an Android build with these changes:
$ nm --defined-only -g -C out/Release/lib.unstripped/libjingle_peerconnection_so.so | grep -i createpeerconnectionf
00077c51 T Java_org_webrtc_PeerConnectionFactory_nativeCreatePeerConnectionFactory
$ nm --defined-only -g -C out/Release/obj/webrtc/api/libjingle_peerconnection.a | grep -i createpeerconnectionf
00000001 T webrtc::CreatePeerConnectionFactory(rtc::Thread*, rtc::Thread*, rtc::Thread*, webrtc::AudioDeviceModule*, cricket::WebRtcVideoEncoderFactory*, cricket::WebRtcVideoDecoderFactory*)
00000001 T webrtc::CreatePeerConnectionFactory()

See https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookbook.md#Note-on-static-libraries
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce
binary bloat and unnecessary linking time. Right now it's more
important to restore the desired build output though.

BUG=webrtc:6410, chromium:630755
Committed: https://crrev.com/b62dbbe985c643cf4ee28e4c73c75bb3ef5e4d54
Cr-Commit-Position: refs/heads/master@{#14364}

[kjellander_webrtc, 2016-09-22 12:39:46]

Description was changed from

==========
GN: Change all rtc_source_set to rtc_static_library.

This should bring back the build behavior we used to have with GYP.
See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

BUG=webrtc:6410
==========

to

==========
GN: Change most rtc_source_set to rtc_static_library.

This changes all rtc_source_set targets except the ones containing
only header files to be rtc_static_library. This should bring back the
build behavior we used to have with GYP (i.e. same symbols exported etc).

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

BUG=webrtc:6410
==========

[kjellander_webrtc, 2016-09-22 12:49:45]

Description was changed from

==========
GN: Change most rtc_source_set to rtc_static_library.

This changes all rtc_source_set targets except the ones containing
only header files to be rtc_static_library. This should bring back the
build behavior we used to have with GYP (i.e. same symbols exported etc).

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

BUG=webrtc:6410
==========

to

==========
GN: Change most rtc_source_set targets --> rtc_static_library

This changes all rtc_source_set targets except the ones without any .cc files to
be rtc_static_library. This should bring back the build behavior
we used to have with GYP (i.e. same symbols exported etc).

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

BUG=webrtc:6410
==========

[kjellander_webrtc, 2016-09-22 12:53:17]

Patchset #2 (id:20001) has been deleted

[kjellander_webrtc, 2016-09-22 12:56:25]

Description was changed from

==========
GN: Change most rtc_source_set targets --> rtc_static_library

This changes all rtc_source_set targets except the ones without any .cc files to
be rtc_static_library. This should bring back the build behavior
we used to have with GYP (i.e. same symbols exported etc).

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

BUG=webrtc:6410
==========

to

==========
GN: Change most rtc_source_set targets --> rtc_static_library

This changes all rtc_source_set targets except the ones without any .cc files to
be rtc_static_library. This should bring back the build behavior
we used to have with GYP (i.e. same symbols exported etc).

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce binary bloat
and unnecessary linking time. Right now it's more important to restore the
desired
build output though.

BUG=webrtc:6410
==========

[kjellander_webrtc, 2016-09-22 13:07:53]

Patchset #2 (id:40001) has been deleted

[kjellander_webrtc, 2016-09-22 13:08:00]

Patchset #2 (id:60001) has been deleted

[kjellander_webrtc, 2016-09-22 13:20:55]

Description was changed from

==========
GN: Change most rtc_source_set targets --> rtc_static_library

This changes all rtc_source_set targets except the ones without any .cc files to
be rtc_static_library. This should bring back the build behavior
we used to have with GYP (i.e. same symbols exported etc).

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce binary bloat
and unnecessary linking time. Right now it's more important to restore the
desired
build output though.

BUG=webrtc:6410
==========

to

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior
we used to have with GYP (i.e. same symbols exported etc).

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce binary bloat
and unnecessary linking time. Right now it's more important to restore the
desired
build output though.

BUG=webrtc:6410
==========

[the sun, 2016-09-22 18:08:10]

solenberg@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[the sun, 2016-09-22 18:08:11]

https://codereview.webrtc.org/2361623004/diff/90001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/BUILD.gn (left):

https://codereview.webrtc.org/2361623004/diff/90001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/BUILD.gn:118: "android/opensles_recorder.h",
intentional?

[kjellander_webrtc, 2016-09-22 19:45:14]

Patchset #4 (id:110001) has been deleted

[kjellander_webrtc, 2016-09-22 20:12:32]

Patchset #4 (id:130001) has been deleted

[kjellander_webrtc, 2016-09-22 20:12:54]

The CQ bit was checked by kjellander@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 20:12:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kjellander_webrtc, 2016-09-22 20:13:33]

kjellander@webrtc.org changed reviewers:
+ brucedawson@chromium.org

[kjellander_webrtc, 2016-09-22 20:13:34]

Thanks for spotting the rebase error Fredrik. 

Do you guys think this will work as is now, given all CQ bots pass? 
I'll double-check a few unit tests to ensure the same number of tests are
executed before submitting.

https://codereview.webrtc.org/2361623004/diff/90001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/BUILD.gn (left):

https://codereview.webrtc.org/2361623004/diff/90001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/BUILD.gn:118: "android/opensles_recorder.h",
On 2016/09/22 18:08:10, the sun wrote:
> intentional?

Huh, what the #€*& ???
I have no idea how that happened. Maybe the cat stepped on the keyboard :)
I guess I didn't pay attention during a rebase or something. Anyway, that
explains the build errors for Android. Thanks for looking!

[kjellander_webrtc, 2016-09-22 20:16:15]

Description was changed from

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior
we used to have with GYP (i.e. same symbols exported etc).

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce binary bloat
and unnecessary linking time. Right now it's more important to restore the
desired
build output though.

BUG=webrtc:6410
==========

to

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported etc).

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce binary bloat
and unnecessary linking time. Right now it's more important to restore the
desired
build output though.

BUG=webrtc:6410
==========

[kjellander_webrtc, 2016-09-22 20:16:38]

Description was changed from

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported etc).

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce binary bloat
and unnecessary linking time. Right now it's more important to restore the
desired
build output though.

BUG=webrtc:6410
==========

to

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported etc).

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce
binary bloat and unnecessary linking time. Right now it's more
important to restore the desired build output though.

BUG=webrtc:6410
==========

[brucedawson, 2016-09-22 20:22:50]

lgtm, and thanks, but if possible please add a reference to chromium bug 630755
to the description. That will give us the benefits mentioned in
https://bugs.chromium.org/p/chromium/issues/detail?id=630755#c1 - although that
does not yet map to actual binary size savings for mysterious reasons.

[commit-bot: I haz the power, 2016-09-22 22:07:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 22:07:04]

Dry run: This issue passed the CQ dry run.

[kjellander_webrtc, 2016-09-23 04:57:56]

Description was changed from

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported etc).

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce
binary bloat and unnecessary linking time. Right now it's more
important to restore the desired build output though.

BUG=webrtc:6410
==========

to

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported etc).

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce
binary bloat and unnecessary linking time. Right now it's more
important to restore the desired build output though.

BUG=webrtc:6410, chromium:630755
==========

[the sun, 2016-09-23 07:22:58]

lgtm

[kjellander_webrtc, 2016-09-23 07:28:08]

Description was changed from

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported etc).

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce
binary bloat and unnecessary linking time. Right now it's more
important to restore the desired build output though.

BUG=webrtc:6410, chromium:630755
==========

to

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported in the libjingle_peerconnection.a file, which
are used by some downstream projects).

After doing an Android build with these changes:
$ nm --defined-only -g -C
out/Release/lib.unstripped/libjingle_peerconnection_so.so | grep -i
createpeerconnectionf
00077c51 T
Java_org_webrtc_PeerConnectionFactory_nativeCreatePeerConnectionFactory
$ nm --defined-only -g -C
out/Release-staticlibs/obj/webrtc/api/libjingle_peerconnection.a | grep -i
createpeerconnectionf
00000001 T webrtc::CreatePeerConnectionFactory(rtc::Thread*, rtc::Thread*,
rtc::Thread*, webrtc::AudioDeviceModule*, cricket::WebRtcVideoEncoderFactory*,
cricket::WebRtcVideoDecoderFactory*)
00000001 T webrtc::CreatePeerConnectionFactory()

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce
binary bloat and unnecessary linking time. Right now it's more
important to restore the desired build output though.

BUG=webrtc:6410, chromium:630755
==========

[kjellander_webrtc, 2016-09-23 07:28:25]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-09-23 07:28:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kjellander_webrtc, 2016-09-23 07:29:06]

Description was changed from

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported in the libjingle_peerconnection.a file, which
are used by some downstream projects).

After doing an Android build with these changes:
$ nm --defined-only -g -C
out/Release/lib.unstripped/libjingle_peerconnection_so.so | grep -i
createpeerconnectionf
00077c51 T
Java_org_webrtc_PeerConnectionFactory_nativeCreatePeerConnectionFactory
$ nm --defined-only -g -C
out/Release-staticlibs/obj/webrtc/api/libjingle_peerconnection.a | grep -i
createpeerconnectionf
00000001 T webrtc::CreatePeerConnectionFactory(rtc::Thread*, rtc::Thread*,
rtc::Thread*, webrtc::AudioDeviceModule*, cricket::WebRtcVideoEncoderFactory*,
cricket::WebRtcVideoDecoderFactory*)
00000001 T webrtc::CreatePeerConnectionFactory()

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce
binary bloat and unnecessary linking time. Right now it's more
important to restore the desired build output though.

BUG=webrtc:6410, chromium:630755
==========

to

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported in the libjingle_peerconnection.a file, which
are used by some downstream projects).

After doing an Android build with these changes:
$ nm --defined-only -g -C
out/Release/lib.unstripped/libjingle_peerconnection_so.so | grep -i
createpeerconnectionf
00077c51 T
Java_org_webrtc_PeerConnectionFactory_nativeCreatePeerConnectionFactory
$ nm --defined-only -g -C out/Release/obj/webrtc/api/libjingle_peerconnection.a
| grep -i createpeerconnectionf
00000001 T webrtc::CreatePeerConnectionFactory(rtc::Thread*, rtc::Thread*,
rtc::Thread*, webrtc::AudioDeviceModule*, cricket::WebRtcVideoEncoderFactory*,
cricket::WebRtcVideoDecoderFactory*)
00000001 T webrtc::CreatePeerConnectionFactory()

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce
binary bloat and unnecessary linking time. Right now it's more
important to restore the desired build output though.

BUG=webrtc:6410, chromium:630755
==========

[commit-bot: I haz the power, 2016-09-23 07:38:55]

Description was changed from

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported in the libjingle_peerconnection.a file, which
are used by some downstream projects).

After doing an Android build with these changes:
$ nm --defined-only -g -C
out/Release/lib.unstripped/libjingle_peerconnection_so.so | grep -i
createpeerconnectionf
00077c51 T
Java_org_webrtc_PeerConnectionFactory_nativeCreatePeerConnectionFactory
$ nm --defined-only -g -C out/Release/obj/webrtc/api/libjingle_peerconnection.a
| grep -i createpeerconnectionf
00000001 T webrtc::CreatePeerConnectionFactory(rtc::Thread*, rtc::Thread*,
rtc::Thread*, webrtc::AudioDeviceModule*, cricket::WebRtcVideoEncoderFactory*,
cricket::WebRtcVideoDecoderFactory*)
00000001 T webrtc::CreatePeerConnectionFactory()

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce
binary bloat and unnecessary linking time. Right now it's more
important to restore the desired build output though.

BUG=webrtc:6410, chromium:630755
==========

to

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported in the libjingle_peerconnection.a file, which
are used by some downstream projects).

After doing an Android build with these changes:
$ nm --defined-only -g -C
out/Release/lib.unstripped/libjingle_peerconnection_so.so | grep -i
createpeerconnectionf
00077c51 T
Java_org_webrtc_PeerConnectionFactory_nativeCreatePeerConnectionFactory
$ nm --defined-only -g -C out/Release/obj/webrtc/api/libjingle_peerconnection.a
| grep -i createpeerconnectionf
00000001 T webrtc::CreatePeerConnectionFactory(rtc::Thread*, rtc::Thread*,
rtc::Thread*, webrtc::AudioDeviceModule*, cricket::WebRtcVideoEncoderFactory*,
cricket::WebRtcVideoDecoderFactory*)
00000001 T webrtc::CreatePeerConnectionFactory()

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce
binary bloat and unnecessary linking time. Right now it's more
important to restore the desired build output though.

BUG=webrtc:6410, chromium:630755
==========

[commit-bot: I haz the power, 2016-09-23 07:38:56]

Committed patchset #4 (id:150001)

[commit-bot: I haz the power, 2016-09-23 07:39:04]

Description was changed from

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported in the libjingle_peerconnection.a file, which
are used by some downstream projects).

After doing an Android build with these changes:
$ nm --defined-only -g -C
out/Release/lib.unstripped/libjingle_peerconnection_so.so | grep -i
createpeerconnectionf
00077c51 T
Java_org_webrtc_PeerConnectionFactory_nativeCreatePeerConnectionFactory
$ nm --defined-only -g -C out/Release/obj/webrtc/api/libjingle_peerconnection.a
| grep -i createpeerconnectionf
00000001 T webrtc::CreatePeerConnectionFactory(rtc::Thread*, rtc::Thread*,
rtc::Thread*, webrtc::AudioDeviceModule*, cricket::WebRtcVideoEncoderFactory*,
cricket::WebRtcVideoDecoderFactory*)
00000001 T webrtc::CreatePeerConnectionFactory()

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce
binary bloat and unnecessary linking time. Right now it's more
important to restore the desired build output though.

BUG=webrtc:6410, chromium:630755
==========

to

==========
GN: Change rtc_source_set targets --> rtc_static_library

This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported in the libjingle_peerconnection.a file, which
are used by some downstream projects).

After doing an Android build with these changes:
$ nm --defined-only -g -C
out/Release/lib.unstripped/libjingle_peerconnection_so.so | grep -i
createpeerconnectionf
00077c51 T
Java_org_webrtc_PeerConnectionFactory_nativeCreatePeerConnectionFactory
$ nm --defined-only -g -C out/Release/obj/webrtc/api/libjingle_peerconnection.a
| grep -i createpeerconnectionf
00000001 T webrtc::CreatePeerConnectionFactory(rtc::Thread*, rtc::Thread*,
rtc::Thread*, webrtc::AudioDeviceModule*, cricket::WebRtcVideoEncoderFactory*,
cricket::WebRtcVideoDecoderFactory*)
00000001 T webrtc::CreatePeerConnectionFactory()

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookboo...
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce
binary bloat and unnecessary linking time. Right now it's more
important to restore the desired build output though.

BUG=webrtc:6410, chromium:630755

Committed: https://crrev.com/b62dbbe985c643cf4ee28e4c73c75bb3ef5e4d54
Cr-Commit-Position: refs/heads/master@{#14364}
==========

[commit-bot: I haz the power, 2016-09-23 07:39:05]

Patchset 4 (id:??) landed as
https://crrev.com/b62dbbe985c643cf4ee28e4c73c75bb3ef5e4d54
Cr-Commit-Position: refs/heads/master@{#14364}

[kjellander_webrtc, 2016-09-23 08:52:38]

On 2016/09/23 07:39:05, commit-bot: I haz the power wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/b62dbbe985c643cf4ee28e4c73c75bb3ef5e4d54
> Cr-Commit-Position: refs/heads/master@{#14364}

I verified the number of tests executed is correct at
https://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/9587
using manual inspection for webrtc_nonparallel_tests, video_engine_tests,
rtc_unittests, system_wrappers_unittests, modules_unittests and modules_tests. I
think that should be sufficient to be sure we're not missing any.

[Michael Achenbach, 2016-09-29 12:40:35]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-09-29 12:40:36]

Did you compare the .a file sizes to the old ones in gyp? In V8 this doesn't
deliver the same thing.

[brucedawson, 2016-09-29 21:25:18]

On 2016/09/29 12:40:36, machenbach (slow) wrote:
> Did you compare the .a file sizes to the old ones in gyp? In V8 this doesn't
> deliver the same thing.

Does webrtc still build with gyp?

What discrepancies are you seeing? Getting exact matches of binaries is very
difficult due to the many subtle differences in the build systems, so some
differences are not surprising.

[kjellander_webrtc, 2016-09-30 06:14:22]

On 2016/09/29 21:25:18, brucedawson wrote:
> On 2016/09/29 12:40:36, machenbach (slow) wrote:
> > Did you compare the .a file sizes to the old ones in gyp? In V8 this doesn't
> > deliver the same thing.

Nope, I didn't go that deep.

> Does webrtc still build with gyp?

No we just maintain a small subset of GYP for a little while longer due to
internal projects.

> What discrepancies are you seeing? Getting exact matches of binaries is very
> difficult due to the many subtle differences in the build systems, so some
> differences are not surprising.

[Michael Achenbach, 2016-09-30 08:07:39]

See https://mail.google.com/mail/u/0/#label/gn-dev/15574884e2f3f9c8 for
reference. It looks like in gyp we had thin archives by default while in GN the
archives are self contained (and therefore bigger).