Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: webrtc/build/no_op_function.cc

Issue 2372983002: Make 'webrtc' a static library. (Closed)
Patch Set: Added TODOs Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/build/no_op_function.cc
diff --git a/webrtc/modules/desktop_capture/screen_drawer_mac.cc b/webrtc/build/no_op_function.cc
similarity index 62%
copy from webrtc/modules/desktop_capture/screen_drawer_mac.cc
copy to webrtc/build/no_op_function.cc
index 1d0437b5a1022b26afaa5942d6abe76066fe455b..4c10e37d39f9b4c89769b7ee72a8357d48156d26 100644
--- a/webrtc/modules/desktop_capture/screen_drawer_mac.cc
+++ b/webrtc/build/no_op_function.cc
@@ -8,15 +8,16 @@
* be found in the AUTHORS file in the root of the source tree.
*/
-// TODO(zijiehe): Implement ScreenDrawerMac
-
-#include "webrtc/modules/desktop_capture/screen_drawer.h"
-
namespace webrtc {
-// static
-std::unique_ptr<ScreenDrawer> ScreenDrawer::Create() {
- return nullptr;
+// TODO(kjellander): Remove this whenever possible. GN's static_library
+// target type requires at least one object to avoid errors linking.
+
+// No-op function that can be used to compile an object necessary
+// for linking into a static library.
+int foobarbaz() {
+ return 0;
}
} // namespace webrtc
+
« no previous file with comments | « webrtc/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698