Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/BUILD.gn

Issue 2372983002: Make 'webrtc' a static library. (Closed)
Patch Set: Added TODOs Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/build/no_op_function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/BUILD.gn
diff --git a/webrtc/BUILD.gn b/webrtc/BUILD.gn
index d2381f3336f9314a69317cbd83422581063fea1c..19d56c3506e2ce56ef25012b3ff5af51c0d82df0 100644
--- a/webrtc/BUILD.gn
+++ b/webrtc/BUILD.gn
@@ -240,8 +240,11 @@ config("common_objc") {
}
if (!is_ios || !build_with_chromium) {
- rtc_source_set("webrtc") {
+ rtc_static_library("webrtc") {
sources = [
+ # TODO(kjellander): Remove this whenever possible. GN's static_library
+ # target type requires at least one object to avoid errors linking.
+ "build/no_op_function.cc",
"call.h",
"config.h",
"transport.h",
« no previous file with comments | « no previous file | webrtc/build/no_op_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698