Issue 2361853002: Replace const -> constexpr for rtcp Packet Type

Issue 2361853002: Replace const -> constexpr for rtcp Packet Type (Closed)

Created:
4 years, 3 months ago by danilchap

Modified:
4 years, 2 months ago

Reviewers:
sprang_webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Replace const -> constexpr for rtcp Packet Type for consistency with other rtcp packet classes. BUG=webrtc:5260 Committed: https://crrev.com/2f255d8d67b61bd57dbd425b1e5e98adeb89bb64 Cr-Commit-Position: refs/heads/master@{#14648}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -15 lines)			Patch
M	webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.cc	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 10 (5 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2361853002/1

4 years, 2 months ago (2016-10-17 08:25:56 UTC) #6

commit-bot: I haz the power

4 years, 2 months ago (2016-10-17 09:08:07 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2f255d8d67b61bd57dbd425b1e5e98adeb89bb64
Cr-Commit-Position: refs/heads/master@{#14648}