Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc

Issue 2361853002: Replace const -> constexpr for rtcp Packet Type (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h" 11 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h"
12 12
13 #include "webrtc/base/checks.h" 13 #include "webrtc/base/checks.h"
14 #include "webrtc/base/logging.h" 14 #include "webrtc/base/logging.h"
15 #include "webrtc/modules/rtp_rtcp/source/byte_io.h" 15 #include "webrtc/modules/rtp_rtcp/source/byte_io.h"
16 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h" 16 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h"
17 17
18 namespace webrtc { 18 namespace webrtc {
19 namespace rtcp { 19 namespace rtcp {
20 // 20 constexpr uint8_t ReceiverReport::kPacketType;
21 // RTCP receiver report (RFC 3550). 21 // RTCP receiver report (RFC 3550).
22 // 22 //
23 // 0 1 2 3 23 // 0 1 2 3
24 // 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 24 // 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
25 // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ 25 // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
26 // |V=2|P| RC | PT=RR=201 | length | 26 // |V=2|P| RC | PT=RR=201 | length |
27 // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ 27 // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
28 // | SSRC of packet sender | 28 // | SSRC of packet sender |
29 // +=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+ 29 // +=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+
30 // | report block(s) | 30 // | report block(s) |
31 // | .... | 31 // | .... |
32 bool ReceiverReport::Parse(const CommonHeader& packet) { 32 bool ReceiverReport::Parse(const CommonHeader& packet) {
33 RTC_DCHECK(packet.type() == kPacketType); 33 RTC_DCHECK_EQ(packet.type(), kPacketType);
34 34
35 const uint8_t report_blocks_count = packet.count(); 35 const uint8_t report_blocks_count = packet.count();
36 36
37 if (packet.payload_size_bytes() < 37 if (packet.payload_size_bytes() <
38 kRrBaseLength + report_blocks_count * ReportBlock::kLength) { 38 kRrBaseLength + report_blocks_count * ReportBlock::kLength) {
39 LOG(LS_WARNING) << "Packet is too small to contain all the data."; 39 LOG(LS_WARNING) << "Packet is too small to contain all the data.";
40 return false; 40 return false;
41 } 41 }
42 42
43 sender_ssrc_ = ByteReader<uint32_t>::ReadBigEndian(packet.payload()); 43 sender_ssrc_ = ByteReader<uint32_t>::ReadBigEndian(packet.payload());
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 if (report_blocks_.size() >= kMaxNumberOfReportBlocks) { 78 if (report_blocks_.size() >= kMaxNumberOfReportBlocks) {
79 LOG(LS_WARNING) << "Max report blocks reached."; 79 LOG(LS_WARNING) << "Max report blocks reached.";
80 return false; 80 return false;
81 } 81 }
82 report_blocks_.push_back(block); 82 report_blocks_.push_back(block);
83 return true; 83 return true;
84 } 84 }
85 85
86 } // namespace rtcp 86 } // namespace rtcp
87 } // namespace webrtc 87 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698