Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.h

Issue 2361853002: Replace const -> constexpr for rtcp Packet Type (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PLI_H_ 10 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PLI_H_
11 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PLI_H_ 11 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PLI_H_
12 12
13 #include "webrtc/base/basictypes.h" 13 #include "webrtc/base/basictypes.h"
14 #include "webrtc/base/constructormagic.h" 14 #include "webrtc/base/constructormagic.h"
15 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h" 15 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h"
16 16
17 namespace webrtc { 17 namespace webrtc {
18 namespace rtcp { 18 namespace rtcp {
19 class CommonHeader; 19 class CommonHeader;
20 // Picture loss indication (PLI) (RFC 4585). 20 // Picture loss indication (PLI) (RFC 4585).
21 class Pli : public Psfb { 21 class Pli : public Psfb {
22 public: 22 public:
23 static const uint8_t kFeedbackMessageType = 1; 23 static constexpr uint8_t kFeedbackMessageType = 1;
24 24
25 Pli() {} 25 Pli() {}
26 ~Pli() override {} 26 ~Pli() override {}
27 27
28 bool Parse(const CommonHeader& packet); 28 bool Parse(const CommonHeader& packet);
29 29
30 protected: 30 protected:
31 bool Create(uint8_t* packet, 31 bool Create(uint8_t* packet,
32 size_t* index, 32 size_t* index,
33 size_t max_length, 33 size_t max_length,
34 RtcpPacket::PacketReadyCallback* callback) const override; 34 RtcpPacket::PacketReadyCallback* callback) const override;
35 35
36 private: 36 private:
37 size_t BlockLength() const override { 37 size_t BlockLength() const override {
38 return kHeaderLength + kCommonFeedbackLength; 38 return kHeaderLength + kCommonFeedbackLength;
39 } 39 }
40 40
41 RTC_DISALLOW_COPY_AND_ASSIGN(Pli); 41 RTC_DISALLOW_COPY_AND_ASSIGN(Pli);
42 }; 42 };
43 43
44 } // namespace rtcp 44 } // namespace rtcp
45 } // namespace webrtc 45 } // namespace webrtc
46 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PLI_H_ 46 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PLI_H_
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698