Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc

Issue 2361853002: Replace const -> constexpr for rtcp Packet Type (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc
index 7fdcc1633a0b95ff62d79f88cec29ca511ee4486..7838fccf8255c659681f29f13698a5c49f8540f3 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc
@@ -16,7 +16,7 @@
namespace webrtc {
namespace rtcp {
-
+constexpr uint8_t Pli::kFeedbackMessageType;
// RFC 4585: Feedback format.
//
// Common packet format:
@@ -37,8 +37,8 @@ namespace rtcp {
// Picture loss indication (PLI) (RFC 4585).
// FCI: no feedback control information.
bool Pli::Parse(const CommonHeader& packet) {
- RTC_DCHECK(packet.type() == kPacketType);
- RTC_DCHECK(packet.fmt() == kFeedbackMessageType);
+ RTC_DCHECK_EQ(packet.type(), kPacketType);
+ RTC_DCHECK_EQ(packet.fmt(), kFeedbackMessageType);
if (packet.payload_size_bytes() < kCommonFeedbackLength) {
LOG(LS_WARNING) << "Packet is too small to be a valid PLI packet";
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.h ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698