Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc

Issue 2361853002: Replace const -> constexpr for rtcp Packet Type (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc
index 8f90ce6bdd432895d9ccceacab336daa9115c478..0f6aff07ff7a1aa50a386b3ae9c65da66098a9b4 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc
@@ -17,6 +17,7 @@
namespace webrtc {
namespace rtcp {
+constexpr uint8_t SenderReport::kPacketType;
// Sender report (SR) (RFC 3550).
// 0 1 2 3
// 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
@@ -43,7 +44,7 @@ SenderReport::SenderReport()
sender_octet_count_(0) {}
bool SenderReport::Parse(const CommonHeader& packet) {
- RTC_DCHECK(packet.type() == kPacketType);
+ RTC_DCHECK_EQ(packet.type(), kPacketType);
const uint8_t report_block_count = packet.count();
if (packet.payload_size_bytes() <
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698