GN Templates: Move common_inherited_config to the template.

GN Templates: Move common_inherited_config to the template.

Remove common_inherited_config from the targets and add it to the
template instead.

BUG=webrtc:6187
NOTRY=True

Committed: https://crrev.com/e9cc68629392b69d622d62f20ddbee79a080fc4b
Cr-Commit-Position: refs/heads/master@{#14069}

[ehmaldonado_webrtc, 2016-09-05 11:51:06]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2016-09-05 12:41:31]

lgtm with a suggestion and a question.

https://codereview.webrtc.org/2311843002/diff/1/webrtc/build/webrtc.gni
File webrtc/build/webrtc.gni (right):

https://codereview.webrtc.org/2311843002/diff/1/webrtc/build/webrtc.gni#newco...
webrtc/build/webrtc.gni:171: rtc_common_inherited_config = webrtc_root +
":common_inherited_config"
Add a separate comment about this one:

Global public configuration that should be applied to all WebRTC targets. You
normally shouldn't need to include this in your target as it's automatically
included when using the rtc_* templates. It set the defines, include paths and
compilation warnings that should be propagated to dependents of the targets
depending on the target having this config.

https://codereview.webrtc.org/2311843002/diff/1/webrtc/build/webrtc.gni#newco...
webrtc/build/webrtc.gni:215: if (defined(invoker.public_configs)) {
I guess this check is needed because public_configs is normally not set, while
that's not the case for configs (which I guess always has something by default
in GN?).

[ehmaldonado_webrtc, 2016-09-05 12:49:59]

PTAL.
I'm not sure if to leave it as it is, or set public_configs =[] as a default for
the rtc_* templates and skip the test.

https://codereview.webrtc.org/2311843002/diff/1/webrtc/build/webrtc.gni
File webrtc/build/webrtc.gni (right):

https://codereview.webrtc.org/2311843002/diff/1/webrtc/build/webrtc.gni#newco...
webrtc/build/webrtc.gni:171: rtc_common_inherited_config = webrtc_root +
":common_inherited_config"
On 2016/09/05 12:41:31, kjellander_webrtc wrote:
> Add a separate comment about this one:
> 
> Global public configuration that should be applied to all WebRTC targets. You
> normally shouldn't need to include this in your target as it's automatically
> included when using the rtc_* templates. It set the defines, include paths and
> compilation warnings that should be propagated to dependents of the targets
> depending on the target having this config.

Done.

https://codereview.webrtc.org/2311843002/diff/1/webrtc/build/webrtc.gni#newco...
webrtc/build/webrtc.gni:215: if (defined(invoker.public_configs)) {
On 2016/09/05 12:41:31, kjellander_webrtc wrote:
> I guess this check is needed because public_configs is normally not set, while
> that's not the case for configs (which I guess always has something by default
> in GN?).

Yes, the default configs is defined in BUILDCONFIG.gn
https://cs.chromium.org/chromium/src/build/config/BUILDCONFIG.gn?l=522

Another approach would be to set as a default public_configs = [] for our
templates, and skip the test here.

[kjellander_webrtc, 2016-09-05 12:57:29]

On 2016/09/05 12:49:59, ehmaldonado_webrtc wrote:
> PTAL.
> I'm not sure if to leave it as it is, or set public_configs =[] as a default
for
> the rtc_* templates and skip the test.

I don't know if there's any consequence that might have. Let's keep it as is -
then we can submit right away too :)

> 
> https://codereview.webrtc.org/2311843002/diff/1/webrtc/build/webrtc.gni
> File webrtc/build/webrtc.gni (right):
> 
>
https://codereview.webrtc.org/2311843002/diff/1/webrtc/build/webrtc.gni#newco...
> webrtc/build/webrtc.gni:171: rtc_common_inherited_config = webrtc_root +
> ":common_inherited_config"
> On 2016/09/05 12:41:31, kjellander_webrtc wrote:
> > Add a separate comment about this one:
> > 
> > Global public configuration that should be applied to all WebRTC targets.
You
> > normally shouldn't need to include this in your target as it's automatically
> > included when using the rtc_* templates. It set the defines, include paths
and
> > compilation warnings that should be propagated to dependents of the targets
> > depending on the target having this config.
> 
> Done.
> 
>
https://codereview.webrtc.org/2311843002/diff/1/webrtc/build/webrtc.gni#newco...
> webrtc/build/webrtc.gni:215: if (defined(invoker.public_configs)) {
> On 2016/09/05 12:41:31, kjellander_webrtc wrote:
> > I guess this check is needed because public_configs is normally not set,
while
> > that's not the case for configs (which I guess always has something by
default
> > in GN?).
> 
> Yes, the default configs is defined in BUILDCONFIG.gn
> https://cs.chromium.org/chromium/src/build/config/BUILDCONFIG.gn?l=522
> 
> Another approach would be to set as a default public_configs = [] for our
> templates, and skip the test here.

[ehmaldonado_webrtc, 2016-09-05 13:02:09]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2016-09-05 13:02:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2311843002/#ps20001 (title:
"Added comment for rtc_common_inherited_config.")

[commit-bot: I haz the power, 2016-09-05 13:02:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-05 13:10:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-05 13:10:25]

Description was changed from

==========
GN Templates: Move common_inherited_config to the template.

Remove common_inherited_config from the targets and add it to the
template instead.

BUG=webrtc:6187
NOTRY=True
==========

to

==========
GN Templates: Move common_inherited_config to the template.

Remove common_inherited_config from the targets and add it to the
template instead.

BUG=webrtc:6187
NOTRY=True

Committed: https://crrev.com/e9cc68629392b69d622d62f20ddbee79a080fc4b
Cr-Commit-Position: refs/heads/master@{#14069}
==========

[commit-bot: I haz the power, 2016-09-05 13:10:27]

Patchset 2 (id:??) landed as
https://crrev.com/e9cc68629392b69d622d62f20ddbee79a080fc4b
Cr-Commit-Position: refs/heads/master@{#14069}