Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: webrtc/tools/BUILD.gn

Issue 2311843002: GN Templates: Move common_inherited_config to the template. (Closed)
Patch Set: Added comment for rtc_common_inherited_config. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/test/fuzzers/BUILD.gn ('k') | webrtc/video/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/tools/BUILD.gn
diff --git a/webrtc/tools/BUILD.gn b/webrtc/tools/BUILD.gn
index d09a8d4507531d36e7176c5589820d5e53a9809d..c5f581f13be55cbe7ddd076ef0e4e7641d8fe4e6 100644
--- a/webrtc/tools/BUILD.gn
+++ b/webrtc/tools/BUILD.gn
@@ -31,7 +31,6 @@ rtc_source_set("command_line_parser") {
deps = [
"../base:gtest_prod",
]
- public_configs = [ "..:common_inherited_config" ]
}
rtc_source_set("video_quality_analysis") {
@@ -40,8 +39,6 @@ rtc_source_set("video_quality_analysis") {
"frame_analyzer/video_quality_analysis.h",
]
- public_configs = [ "..:common_inherited_config" ]
-
deps = [
"../common_video",
]
@@ -55,8 +52,6 @@ rtc_executable("frame_analyzer") {
"frame_analyzer/frame_analyzer.cc",
]
- public_configs = [ "..:common_inherited_config" ]
-
deps = [
":command_line_parser",
":video_quality_analysis",
@@ -69,8 +64,6 @@ rtc_executable("psnr_ssim_analyzer") {
"psnr_ssim_analyzer/psnr_ssim_analyzer.cc",
]
- public_configs = [ "..:common_inherited_config" ]
-
deps = [
":command_line_parser",
":video_quality_analysis",
@@ -85,8 +78,6 @@ rtc_executable("rgba_to_i420_converter") {
"converter/rgba_to_i420_converter.cc",
]
- public_configs = [ "..:common_inherited_config" ]
-
deps = [
":command_line_parser",
"../common_video",
@@ -100,8 +91,6 @@ rtc_source_set("frame_editing_lib") {
"frame_editing/frame_editing_lib.h",
]
- public_configs = [ "..:common_inherited_config" ]
-
# TODO(jschuh): Bug 1348: fix this warning.
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
@@ -121,8 +110,6 @@ rtc_executable("frame_editor") {
"frame_editing/frame_editing.cc",
]
- public_configs = [ "..:common_inherited_config" ]
-
deps = [
":command_line_parser",
":frame_editing_lib",
@@ -135,8 +122,6 @@ rtc_executable("force_mic_volume_max") {
"force_mic_volume_max/force_mic_volume_max.cc",
]
- public_configs = [ "..:common_inherited_config" ]
-
if (is_clang) {
# Suppress warnings from the Chromium Clang plugin.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
@@ -169,7 +154,6 @@ if (rtc_enable_protobuf) {
"event_log_visualizer/plot_python.cc",
"event_log_visualizer/plot_python.h",
]
- public_configs = [ "..:common_inherited_config" ]
if (is_clang && !is_nacl) {
# Suppress warnings from the Chromium Clang plugin.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
@@ -200,8 +184,6 @@ if (rtc_include_tests) {
"event_log_visualizer/main.cc",
]
- public_configs = [ "..:common_inherited_config" ]
-
if (is_clang && !is_nacl) {
# Suppress warnings from the Chromium Clang plugin.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
@@ -222,8 +204,6 @@ if (rtc_include_tests) {
"agc/activity_metric.cc",
]
- public_configs = [ "..:common_inherited_config" ]
-
if (is_clang) {
# Suppress warnings from the Chromium Clang plugin.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
@@ -245,8 +225,6 @@ if (rtc_include_tests) {
"e2e_quality/audio/audio_e2e_harness.cc",
]
- public_configs = [ "..:common_inherited_config" ]
-
if (is_clang) {
# Suppress warnings from the Chromium Clang plugin.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
@@ -286,8 +264,6 @@ if (rtc_include_tests) {
"simple_command_line_parser_unittest.cc",
]
- public_configs = [ "..:common_inherited_config" ]
-
# TODO(jschuh): Bug 1348: fix this warning.
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
« no previous file with comments | « webrtc/test/fuzzers/BUILD.gn ('k') | webrtc/video/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698