Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: webrtc/media/BUILD.gn

Issue 2311843002: GN Templates: Move common_inherited_config to the template. (Closed)
Patch Set: Added comment for rtc_common_inherited_config. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/libjingle/xmpp/BUILD.gn ('k') | webrtc/modules/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/config/linux/pkg_config.gni") 9 import("//build/config/linux/pkg_config.gni")
10 import("../build/webrtc.gni") 10 import("../build/webrtc.gni")
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 "engine/webrtcvideoframefactory.h", 112 "engine/webrtcvideoframefactory.h",
113 "engine/webrtcvoe.h", 113 "engine/webrtcvoe.h",
114 "engine/webrtcvoiceengine.cc", 114 "engine/webrtcvoiceengine.cc",
115 "engine/webrtcvoiceengine.h", 115 "engine/webrtcvoiceengine.h",
116 "sctp/sctpdataengine.cc", 116 "sctp/sctpdataengine.cc",
117 "sctp/sctpdataengine.h", 117 "sctp/sctpdataengine.h",
118 ] 118 ]
119 119
120 configs += [ ":rtc_media_warnings_config" ] 120 configs += [ ":rtc_media_warnings_config" ]
121 121
122 public_configs = [ "..:common_inherited_config" ]
123
124 if (is_clang) { 122 if (is_clang) {
125 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 123 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
126 suppressed_configs += [ 124 suppressed_configs += [
127 "//build/config/clang:extra_warnings", 125 "//build/config/clang:extra_warnings",
128 "//build/config/clang:find_bad_constructs", 126 "//build/config/clang:find_bad_constructs",
129 ] 127 ]
130 } 128 }
131 129
132 if (is_win) { 130 if (is_win) {
133 cflags = [ 131 cflags = [
(...skipping 22 matching lines...) Expand all
156 154
157 if (rtc_build_usrsctp) { 155 if (rtc_build_usrsctp) {
158 include_dirs += [ 156 include_dirs += [
159 # TODO(jiayl): move this into the public_configs of 157 # TODO(jiayl): move this into the public_configs of
160 # //third_party/usrsctp/BUILD.gn. 158 # //third_party/usrsctp/BUILD.gn.
161 "//third_party/usrsctp/usrsctplib", 159 "//third_party/usrsctp/usrsctplib",
162 ] 160 ]
163 deps += [ "//third_party/usrsctp" ] 161 deps += [ "//third_party/usrsctp" ]
164 } 162 }
165 163
164 public_configs = []
166 if (build_with_chromium) { 165 if (build_with_chromium) {
167 deps += [ "../modules/video_capture:video_capture" ] 166 deps += [ "../modules/video_capture:video_capture" ]
168 } else { 167 } else {
169 public_configs += [ ":rtc_media_defines_config" ] 168 public_configs += [ ":rtc_media_defines_config" ]
170 deps += [ "../modules/video_capture:video_capture_internal_impl" ] 169 deps += [ "../modules/video_capture:video_capture_internal_impl" ]
171 } 170 }
172 if (is_linux && rtc_use_gtk) { 171 if (is_linux && rtc_use_gtk) {
173 sources += [ 172 sources += [
174 "devices/gtkvideorenderer.cc", 173 "devices/gtkvideorenderer.cc",
175 "devices/gtkvideorenderer.h", 174 "devices/gtkvideorenderer.h",
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 "engine/fakewebrtccall.cc", 240 "engine/fakewebrtccall.cc",
242 "engine/fakewebrtccall.h", 241 "engine/fakewebrtccall.h",
243 "engine/fakewebrtcdeviceinfo.h", 242 "engine/fakewebrtcdeviceinfo.h",
244 "engine/fakewebrtcvcmfactory.h", 243 "engine/fakewebrtcvcmfactory.h",
245 "engine/fakewebrtcvideocapturemodule.h", 244 "engine/fakewebrtcvideocapturemodule.h",
246 "engine/fakewebrtcvideoengine.h", 245 "engine/fakewebrtcvideoengine.h",
247 "engine/fakewebrtcvoiceengine.h", 246 "engine/fakewebrtcvoiceengine.h",
248 ] 247 ]
249 248
250 configs += [ ":rtc_unittest_main_config" ] 249 configs += [ ":rtc_unittest_main_config" ]
251 public_configs = [ "..:common_inherited_config" ]
252 250
253 if (rtc_build_libyuv) { 251 if (rtc_build_libyuv) {
254 deps += [ "$rtc_libyuv_dir" ] 252 deps += [ "$rtc_libyuv_dir" ]
255 public_deps += [ "$rtc_libyuv_dir" ] 253 public_deps += [ "$rtc_libyuv_dir" ]
256 } else { 254 } else {
257 # Need to add a directory normally exported by libyuv. 255 # Need to add a directory normally exported by libyuv.
258 include_dirs += [ "$rtc_libyuv_dir/include" ] 256 include_dirs += [ "$rtc_libyuv_dir/include" ]
259 } 257 }
260 258
261 if (is_clang) { 259 if (is_clang) {
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
337 "engine/webrtcmediaengine_unittest.cc", 335 "engine/webrtcmediaengine_unittest.cc",
338 "engine/webrtcvideocapturer_unittest.cc", 336 "engine/webrtcvideocapturer_unittest.cc",
339 "engine/webrtcvideoengine2_unittest.cc", 337 "engine/webrtcvideoengine2_unittest.cc",
340 "engine/webrtcvideoframe_unittest.cc", 338 "engine/webrtcvideoframe_unittest.cc",
341 "engine/webrtcvideoframefactory_unittest.cc", 339 "engine/webrtcvideoframefactory_unittest.cc",
342 "engine/webrtcvoiceengine_unittest.cc", 340 "engine/webrtcvoiceengine_unittest.cc",
343 "sctp/sctpdataengine_unittest.cc", 341 "sctp/sctpdataengine_unittest.cc",
344 ] 342 ]
345 343
346 configs += [ ":rtc_media_unittests_config" ] 344 configs += [ ":rtc_media_unittests_config" ]
347 public_configs = [ "..:common_inherited_config" ]
348 345
349 if (rtc_use_h264) { 346 if (rtc_use_h264) {
350 defines += [ "WEBRTC_USE_H264" ] 347 defines += [ "WEBRTC_USE_H264" ]
351 } 348 }
352 if (is_win) { 349 if (is_win) {
353 cflags = [ 350 cflags = [
354 "/wd4245", # conversion from int to size_t, signed/unsigned mismatch. 351 "/wd4245", # conversion from int to size_t, signed/unsigned mismatch.
355 "/wd4373", # virtual function override. 352 "/wd4373", # virtual function override.
356 "/wd4389", # signed/unsigned mismatch. 353 "/wd4389", # signed/unsigned mismatch.
357 ] 354 ]
(...skipping 20 matching lines...) Expand all
378 deps += [ 375 deps += [
379 # TODO(kjellander): Move as part of work in bugs.webrtc.org/4243. 376 # TODO(kjellander): Move as part of work in bugs.webrtc.org/4243.
380 ":rtc_media", 377 ":rtc_media",
381 ":rtc_unittest_main", 378 ":rtc_unittest_main",
382 "../audio", 379 "../audio",
383 "../base:rtc_base_tests_utils", 380 "../base:rtc_base_tests_utils",
384 "../system_wrappers:metrics_default", 381 "../system_wrappers:metrics_default",
385 ] 382 ]
386 } 383 }
387 } 384 }
OLDNEW
« no previous file with comments | « webrtc/libjingle/xmpp/BUILD.gn ('k') | webrtc/modules/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698