Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: webrtc/voice_engine/BUILD.gn

Issue 2311843002: GN Templates: Move common_inherited_config to the template. (Closed)
Patch Set: Added comment for rtc_common_inherited_config. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/video/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../build/webrtc.gni") 9 import("../build/webrtc.gni")
10 10
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 71
72 if (is_win) { 72 if (is_win) {
73 defines = [ "WEBRTC_DRIFT_COMPENSATION_SUPPORTED" ] 73 defines = [ "WEBRTC_DRIFT_COMPENSATION_SUPPORTED" ]
74 74
75 cflags = [ 75 cflags = [
76 # TODO(kjellander): Bug 261: fix this warning. 76 # TODO(kjellander): Bug 261: fix this warning.
77 "/wd4373", # Virtual function override. 77 "/wd4373", # Virtual function override.
78 ] 78 ]
79 } 79 }
80 80
81 public_configs = [ "..:common_inherited_config" ]
82
83 if (is_clang) { 81 if (is_clang) {
84 # Suppress warnings from Chrome's Clang plugins. 82 # Suppress warnings from Chrome's Clang plugins.
85 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. 83 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
86 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 84 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
87 } 85 }
88 86
89 deps = [ 87 deps = [
90 ":level_indicator", 88 ":level_indicator",
91 "..:rtc_event_log", 89 "..:rtc_event_log",
92 "..:webrtc_common", 90 "..:webrtc_common",
(...skipping 12 matching lines...) Expand all
105 "../system_wrappers", 103 "../system_wrappers",
106 ] 104 ]
107 } 105 }
108 106
109 rtc_source_set("level_indicator") { 107 rtc_source_set("level_indicator") {
110 sources = [ 108 sources = [
111 "level_indicator.cc", 109 "level_indicator.cc",
112 "level_indicator.h", 110 "level_indicator.h",
113 ] 111 ]
114 112
115 public_configs = [ "..:common_inherited_config" ]
116
117 deps = [ 113 deps = [
118 "..:webrtc_common", 114 "..:webrtc_common",
119 "../base:rtc_base_approved", 115 "../base:rtc_base_approved",
120 "../common_audio", 116 "../common_audio",
121 ] 117 ]
122 } 118 }
123 119
124 if (rtc_include_tests) { 120 if (rtc_include_tests) {
125 rtc_test("voice_engine_unittests") { 121 rtc_test("voice_engine_unittests") {
126 deps = [ 122 deps = [
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 } 256 }
261 257
262 if (is_clang) { 258 if (is_clang) {
263 # Suppress warnings from Chrome's Clang plugins. 259 # Suppress warnings from Chrome's Clang plugins.
264 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. 260 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
265 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 261 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
266 } 262 }
267 } 263 }
268 } 264 }
269 } 265 }
OLDNEW
« no previous file with comments | « webrtc/video/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698