Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: webrtc/test/BUILD.gn

Issue 2311843002: GN Templates: Move common_inherited_config to the template. (Closed)
Patch Set: Added comment for rtc_common_inherited_config. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/system_wrappers/BUILD.gn ('k') | webrtc/test/fuzzers/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/BUILD.gn
diff --git a/webrtc/test/BUILD.gn b/webrtc/test/BUILD.gn
index 988c2d5fe251d4e8c2060a369bb5a68a70b4b545..6b6a2bb33f432b08962a4e553ee58cf5a3bb70c1 100644
--- a/webrtc/test/BUILD.gn
+++ b/webrtc/test/BUILD.gn
@@ -75,7 +75,6 @@ rtc_source_set("channel_transport") {
]
configs += [ ":channel_transport_warnings_config" ]
- public_configs = [ "..:common_inherited_config" ]
if (is_clang && !is_nacl) {
# Suppress warnings from the Chromium Clang plugin.
@@ -101,8 +100,6 @@ rtc_source_set("video_test_common") {
"frame_utils.h",
]
- public_configs = [ "..:common_inherited_config" ]
-
if (is_clang && !is_nacl) {
# Suppress warnings from the Chromium Clang plugin.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
@@ -125,8 +122,6 @@ rtc_source_set("rtp_test_utils") {
"rtp_file_writer.h",
]
- public_configs = [ "..:common_inherited_config" ]
-
if (is_clang && !is_nacl) {
# Suppress warnings from the Chromium Clang plugin.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
@@ -152,8 +147,6 @@ rtc_source_set("field_trial") {
"../system_wrappers",
"../system_wrappers:field_trial_default",
]
-
- public_configs = [ "..:common_inherited_config" ]
}
rtc_source_set("test_main") {
@@ -169,8 +162,6 @@ rtc_source_set("test_main") {
"//testing/gtest",
"//third_party/gflags",
]
-
- public_configs = [ "..:common_inherited_config" ]
}
rtc_source_set("test_support") {
@@ -221,8 +212,6 @@ rtc_source_set("test_support") {
if (is_android) {
deps += [ "//base:base" ]
}
-
- public_configs = [ "..:common_inherited_config" ]
}
# Depend on this target when you want to have test_support but also the
@@ -244,8 +233,6 @@ rtc_source_set("test_support_main") {
"//testing/gtest",
"//third_party/gflags",
]
-
- public_configs = [ "..:common_inherited_config" ]
}
# Depend on this target when you want to have test_support and a special
@@ -262,8 +249,6 @@ rtc_source_set("test_support_main_threaded_mac") {
"testsupport/mac/run_threaded_main_mac.mm",
]
- public_configs = [ "..:common_inherited_config" ]
-
deps = [
":test_support",
]
@@ -312,8 +297,6 @@ rtc_test("test_support_unittests") {
"testsupport/unittest_utils.h",
]
- public_configs = [ "..:common_inherited_config" ]
-
# TODO(jschuh): Bug 1348: fix this warning.
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
@@ -395,8 +378,6 @@ rtc_source_set("test_common") {
]
}
- public_configs = [ "..:common_inherited_config" ]
-
if (is_clang && !is_nacl) {
# Suppress warnings from the Chromium Clang plugin.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
@@ -477,10 +458,7 @@ rtc_source_set("test_renderer") {
]
}
- public_configs = [
- "..:common_inherited_config",
- ":test_renderer_exported_config",
- ]
+ public_configs = [ ":test_renderer_exported_config" ]
if (is_clang && !is_nacl) {
# Suppress warnings from the Chromium Clang plugin.
« no previous file with comments | « webrtc/system_wrappers/BUILD.gn ('k') | webrtc/test/fuzzers/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698