Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2305143003: webkitpy: Make all regex strings use raw string literals. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Make all regex strings use raw string literals. This fixes the anomalous-backslash-in-string pylint warnings. The advantage of using raw string literals is that it makes the behavior of backslashes a little easier to understand; with normal string literals, "\a\b\c" is "<BEL><BS><backslash><lower-case-c>", whereas with raw string literals, each of those backslashes is just a backslash character. The advantage of this pylint warning in general is that enforces escaping literal backslashes in regular strings, which makes it clear that a backslash was intended rather than an escape sequence. BUG=643937 Committed: https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed Cr-Commit-Position: refs/heads/master@{#416636}

Patch Set 1 #

Patch Set 2 : Make all regex strings raw strings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -35 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checker.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/patchreader.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
qyearsley
4 years, 3 months ago (2016-09-05 00:18:19 UTC) #2
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-06 01:25:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2305143003/20001
4 years, 3 months ago (2016-09-06 14:56:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 16:20:58 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 16:27:13 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7beb14b269407802ce44aad29b778529ee473ed
Cr-Commit-Position: refs/heads/master@{#416636}

Powered by Google App Engine
This is Rietveld 408576698