third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py - Issue 2305143003: webkitpy: Make all regex strings use raw string literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py

Issue 2305143003: webkitpy: Make all regex strings use raw string literals. (Closed)

Patch Set: Make all regex strings raw strings. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py

index 03d259f9282be9a3e599c0f427aa83ff6fea185c..aee2f8c32a3a4ee95a71472c0352427a1f6d641f 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py

@@ -821,7 +821,7 @@ class RunTest(unittest.TestCase, StreamTestingMixin):

_, err, _ = logging_run(['--details', 'virtual/virtual_passes/passes/reftest.html'], tests_included=True)

self.assertTrue('ref: virtual/virtual_passes/passes/reftest-expected.html' in err.getvalue())

self.assertTrue(

- re.search('args: --virtual-arg\s*reference_args: --virtual-arg\s*ref:', err.getvalue()))

+ re.search(r'args: --virtual-arg\s*reference_args: --virtual-arg\s*ref:', err.getvalue()))

def test_reftest_virtual_references_use_default_args(self):

test_name = 'virtual/references_use_default_args/passes/reftest.html'

@@ -832,7 +832,7 @@ class RunTest(unittest.TestCase, StreamTestingMixin):

self.assertEqual(test_result.test_name, test_name)

self.assertEqual(test_result.references[0], 'passes/reftest-expected.html')

# reference_args should be empty since we are using the default flags.

- self.assertTrue(re.search('reference_args:\s*ref:', err.getvalue()))

+ self.assertTrue(re.search(r'reference_args:\s*ref:', err.getvalue()))

def test_reftest_matching_text_expectation(self):

test_name = 'passes/reftest.html'