third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py - Issue 2305143003: webkitpy: Make all regex strings use raw string literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py

Issue 2305143003: webkitpy: Make all regex strings use raw string literals. (Closed)

Patch Set: Make all regex strings raw strings. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/style/checker.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py

index 7dcfe2c2ea86275b252a4d1325b454ef6300bf98..2372fdf27d0eb39bd06306ccbc69b80ae60dc498 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py

@@ -138,18 +138,18 @@ class VerboseTest(RegularTest):

buflist = self._basic([0, 1, 2.1, 13, 14.1234])

# We don't bother to match the hours and minutes of the timestamp since

# the local timezone can vary and we can't set that portably and easily.

- self.assertTrue(re.match('\d\d:\d\d:00.000 8675 foo\n', buflist[0]))

- self.assertTrue(re.match('\d\d:\d\d:01.000 8675 bar\n', buflist[1]))

- self.assertTrue(re.match('\d\d:\d\d:13.000 8675 baz 2\n', buflist[2]))

- self.assertTrue(re.match('\d\d:\d\d:14.123 8675 done\n', buflist[3]))

+ self.assertTrue(re.match(r'\d\d:\d\d:00.000 8675 foo\n', buflist[0]))

+ self.assertTrue(re.match(r'\d\d:\d\d:01.000 8675 bar\n', buflist[1]))

+ self.assertTrue(re.match(r'\d\d:\d\d:13.000 8675 baz 2\n', buflist[2]))

+ self.assertTrue(re.match(r'\d\d:\d\d:14.123 8675 done\n', buflist[3]))

self.assertEqual(len(buflist), 4)

def test_log_after_update(self):

buflist = self._log_after_update()

- self.assertTrue(re.match('\d\d:\d\d:00.000 8675 foo\n', buflist[0]))

+ self.assertTrue(re.match(r'\d\d:\d\d:00.000 8675 foo\n', buflist[0]))

# The second argument should have a real timestamp and pid, so we just check the format.

- self.assertTrue(re.match('\d\d:\d\d:\d\d.\d\d\d \d+ bar\n', buflist[1]))

+ self.assertTrue(re.match(r'\d\d:\d\d:\d\d.\d\d\d \d+ bar\n', buflist[1]))

self.assertEqual(len(buflist), 2)