third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py - Issue 2305143003: webkitpy: Make all regex strings use raw string literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py

Issue 2305143003: webkitpy: Make all regex strings use raw string literals. (Closed)

Patch Set: Make all regex strings raw strings. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py

index 7f4985bbe9717da8111dfefcdbae208ec79019a2..c4d4abf11437e8b259bb227905a5f87e27b88283 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py

@@ -200,7 +200,7 @@ class Git(SCM):

return self._run_git(['log', '-1', '--grep=' + grep_str, '--date=iso', self.find_checkout_root(path)])

def _commit_position_from_git_log(self, git_log):

- match = re.search("^\s*Cr-Commit-Position:.*@\{#(?P<commit_position>\d+)\}", git_log, re.MULTILINE)

+ match = re.search(r"^\s*Cr-Commit-Position:.*@\{#(?P<commit_position>\d+)\}", git_log, re.MULTILINE)

if not match:

return ""

return int(match.group('commit_position'))

@@ -214,7 +214,7 @@ class Git(SCM):

def timestamp_of_revision(self, path, revision):

git_log = self.most_recent_log_matching(self._commit_position_regex_for_timestamp() % revision, path)

- match = re.search("^Date:\s*(\d{4})-(\d{2})-(\d{2}) (\d{2}):(\d{2}):(\d{2}) ([+-])(\d{2})(\d{2})$", git_log, re.MULTILINE)

+ match = re.search(r"^Date:\s*(\d{4})-(\d{2})-(\d{2}) (\d{2}):(\d{2}):(\d{2}) ([+-])(\d{2})(\d{2})$", git_log, re.MULTILINE)

if not match:

return ""

@@ -308,7 +308,7 @@ class Git(SCM):

def _branch_tracking_remote_master(self):

origin_info = self._run_git(['remote', 'show', 'origin', '-n'])

- match = re.search("^\s*(?P<branch_name>\S+)\s+merges with remote master$", origin_info, re.MULTILINE)

+ match = re.search(r"^\s*(?P<branch_name>\S+)\s+merges with remote master$", origin_info, re.MULTILINE)

if not match:

raise ScriptError(message="Unable to find local branch tracking origin/master.")

branch = str(match.group("branch_name"))