Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py

Issue 2305143003: webkitpy: Make all regex strings use raw string literals. (Closed)
Patch Set: Make all regex strings raw strings. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2009, Google Inc. All rights reserved. 1 # Copyright (c) 2009, Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 def _wait_on_list_response(cls, list_items, can_choose_multiple, raw_input): 83 def _wait_on_list_response(cls, list_items, can_choose_multiple, raw_input):
84 while True: 84 while True:
85 if can_choose_multiple: 85 if can_choose_multiple:
86 response = cls.prompt( 86 response = cls.prompt(
87 "Enter one or more numbers (comma-separated) or ranges (e.g. 3-7), or \"all\": ", raw_input=raw_input) 87 "Enter one or more numbers (comma-separated) or ranges (e.g. 3-7), or \"all\": ", raw_input=raw_input)
88 if not response.strip() or response == "all": 88 if not response.strip() or response == "all":
89 return list_items 89 return list_items
90 90
91 try: 91 try:
92 indices = [] 92 indices = []
93 for value in re.split("\s*,\s*", response): 93 for value in re.split(r"\s*,\s*", response):
94 parts = value.split('-') 94 parts = value.split('-')
95 if len(parts) == 2: 95 if len(parts) == 2:
96 indices += range(int(parts[0]) - 1, int(parts[1])) 96 indices += range(int(parts[0]) - 1, int(parts[1]))
97 else: 97 else:
98 indices.append(int(value) - 1) 98 indices.append(int(value) - 1)
99 except ValueError: 99 except ValueError:
100 continue 100 continue
101 101
102 return [list_items[i] for i in indices] 102 return [list_items[i] for i in indices]
103 else: 103 else:
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 try: 144 try:
145 webbrowser.get() 145 webbrowser.get()
146 return True 146 return True
147 except webbrowser.Error: 147 except webbrowser.Error:
148 return False 148 return False
149 149
150 def open_url(self, url): 150 def open_url(self, url):
151 if not self.can_open_url(): 151 if not self.can_open_url():
152 _log.warning("Failed to open %s", url) 152 _log.warning("Failed to open %s", url)
153 webbrowser.open(url) 153 webbrowser.open(url)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698