Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 2005873002: Let PacketSource::NextPacket() return an std::unique_ptr (Closed)

Created:
4 years, 7 months ago by hlundin-webrtc
Modified:
4 years, 7 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Let PacketSource::NextPacket() return an std::unique_ptr The return type of PacketSource::NextPacket() is changed from a naked pointer to an std::uniqe_ptr. The interface contract was and still is that the ownership is passed from the callee to the caller, but a unique_ptr makes this explicit. BUG=webrtc:2692 Committed: https://crrev.com/46ba49c622d305dff756d4d228d9ec953a2aea4e Cr-Commit-Position: refs/heads/master@{#12884}

Patch Set 1 #

Total comments: 11

Patch Set 2 : Updating after review #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -57 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receive_test_oldapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.h View 1 2 chunks +3 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc View 1 2 5 chunks +8 lines, -12 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/packet_source.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.cc View 1 3 chunks +4 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/rtp_file_source.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
hlundin-webrtc
kwiberg, please, turn your unique_ptr-sensitive eyes to this CL.
4 years, 7 months ago (2016-05-23 15:16:31 UTC) #2
kwiberg-webrtc
lgtm I have some comments about the comments. tl;dr: There's very little need to explicitly ...
4 years, 7 months ago (2016-05-24 09:04:56 UTC) #3
hlundin-webrtc
Updating after review
4 years, 7 months ago (2016-05-24 10:58:06 UTC) #4
hlundin-webrtc
Thanks. https://codereview.webrtc.org/2005873002/diff/1/webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.h File webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.h (right): https://codereview.webrtc.org/2005873002/diff/1/webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.h#newcode65 webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.h:65: // object is transferred to the caller. On ...
4 years, 7 months ago (2016-05-24 10:59:15 UTC) #5
kwiberg-webrtc
lgtm https://codereview.webrtc.org/2005873002/diff/1/webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h File webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h (left): https://codereview.webrtc.org/2005873002/diff/1/webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h#oldcode35 webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h:35: // the source is infinite. On 2016/05/24 10:59:15, ...
4 years, 7 months ago (2016-05-24 11:26:47 UTC) #6
hlundin-webrtc
rebase
4 years, 7 months ago (2016-05-24 13:48:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005873002/40001
4 years, 7 months ago (2016-05-24 13:49:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-24 15:50:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005873002/40001
4 years, 7 months ago (2016-05-25 05:45:28 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-25 05:50:53 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 05:51:00 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/46ba49c622d305dff756d4d228d9ec953a2aea4e
Cr-Commit-Position: refs/heads/master@{#12884}

Powered by Google App Engine
This is Rietveld 408576698