webrtc/modules/audio_coding/neteq/neteq_unittest.cc - Issue 2005873002: Let PacketSource::NextPacket() return an std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/neteq_unittest.cc

Issue 2005873002: Let PacketSource::NextPacket() return an std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc ('k') | webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/neteq/neteq_unittest.cc

diff --git a/webrtc/modules/audio_coding/neteq/neteq_unittest.cc b/webrtc/modules/audio_coding/neteq/neteq_unittest.cc

index 4a6f505fc639c4edb0b515f712a471ec0c9237cc..24a8774ae4797b40ec1e388be5fac5e1d4069877 100644

--- a/webrtc/modules/audio_coding/neteq/neteq_unittest.cc

+++ b/webrtc/modules/audio_coding/neteq/neteq_unittest.cc

@@ -349,7 +349,7 @@ void NetEqDecodingTest::Process() {

(output_sample_rate_ / 1000))));

}

// Get next packet.

- packet_.reset(rtp_source_->NextPacket());

+ packet_ = rtp_source_->NextPacket();

}

// Get audio from NetEq.

@@ -387,7 +387,7 @@ void NetEqDecodingTest::DecodeAndCompare(

gen_ref ? webrtc::test::OutputPath() + "neteq_rtcp_stats.dat" : "";

ResultSink rtcp_stats(rtcp_out_file);

- packet_.reset(rtp_source_->NextPacket());

+ packet_ = rtp_source_->NextPacket();

int i = 0;

while (packet_) {

std::ostringstream ss;