webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h - Issue 2005873002: Let PacketSource::NextPacket() return an std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h

Issue 2005873002: Let PacketSource::NextPacket() return an std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/neteq/neteq_unittest.cc ('k') | webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h

diff --git a/webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h b/webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h

index 69723035410c2b03d02bfd9d6f4b13395f708395..d1f88771b984e4ad0a83b255ce27f6e38687e65f 100644

--- a/webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h

+++ b/webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h

@@ -31,9 +31,7 @@ class ConstantPcmPacketSource : public PacketSource {

int sample_rate_hz,

int payload_type);

- // Returns a pointer to the next packet. Will never return NULL. That is,

- // the source is infinite.

- Packet* NextPacket() override;

+ std::unique_ptr<Packet> NextPacket() override;

private:

void WriteHeader(uint8_t* packet_memory);