Let PacketSource::NextPacket() return an std::unique_ptr

webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 13 matching lines @@
 // This class implements a packet source that delivers PCM16b encoded packets
 // with a constant sample value. The payload length, constant sample value,
 // sample rate, and payload type are all set in the constructor.
 class ConstantPcmPacketSource : public PacketSource {
  public:
   ConstantPcmPacketSource(size_t payload_len_samples,
                           int16_t sample_value,
                           int sample_rate_hz,
                           int payload_type);
 
-  // Returns a pointer to the next packet. Will never return NULL. That is,
-  // the source is infinite.

[kwiberg-webrtc, 2016/05/24 09:04:56]

Is this comment no longer necessary? To me it looks useful...

[hlundin-webrtc, 2016/05/24 10:59:15]

I try to only document interface methods in the interface declaration. This is
an override, and having the same comment copied here will eventually lead to
discrepancies.

[kwiberg-webrtc, 2016/05/24 11:26:47]

Acknowledged.

-  Packet* NextPacket() override;
+  std::unique_ptr<Packet> NextPacket() override;
 
  private:
   void WriteHeader(uint8_t* packet_memory);
 
   const size_t kHeaderLenBytes = 12;
   const size_t payload_len_samples_;
   const size_t packet_len_bytes_;
   uint8_t encoded_sample_[2];
   const int samples_per_ms_;
   double next_arrival_time_ms_;
   const int payload_type_;
   uint16_t seq_number_;
   uint32_t timestamp_;
   const uint32_t payload_ssrc_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(ConstantPcmPacketSource);
 };
 
 }  // namespace test
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_AUDIO_CODING_NETEQ_TOOLS_CONSTANT_PCM_PACKET_SOURCE_H_