webrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc - Issue 2005873002: Let PacketSource::NextPacket() return an std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc

Issue 2005873002: Let PacketSource::NextPacket() return an std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.cc ('k') | webrtc/modules/audio_coding/neteq/tools/rtp_file_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc

diff --git a/webrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc b/webrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc

index 0735b4c388d50b8672a99a9e49f3025188409e71..74c64e0a8a486777adbb9175380971879cfd1904 100644

--- a/webrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc

+++ b/webrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc

@@ -107,7 +107,7 @@ int main(int argc, char* argv[]) {

int cycles = -1;

std::unique_ptr<webrtc::test::Packet> packet;

while (true) {

- packet.reset(file_source->NextPacket());

+ packet = file_source->NextPacket();

if (!packet.get()) {

// End of file reached.

break;