Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1821083002: Split ByteBuffer into writer/reader objects. (Closed)

Created:
4 years, 9 months ago by joachim
Modified:
4 years, 8 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Split ByteBuffer into writer/reader objects. This allows the reader to reference data, thus avoiding unnecessary allocations and memory copies. BUG=webrtc:5155, webrtc:5670 Committed: https://crrev.com/f1f87203d703445ca52ef77d28b7ef0591f79cab Cr-Commit-Position: refs/heads/master@{#12160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+463 lines, -429 lines) Patch
M webrtc/api/sctputils.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/base/bitbuffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/bytebuffer.h View 2 chunks +69 lines, -53 lines 0 comments Download
M webrtc/base/bytebuffer.cc View 4 chunks +129 lines, -115 lines 0 comments Download
M webrtc/base/bytebuffer_unittest.cc View 3 chunks +47 lines, -60 lines 0 comments Download
M webrtc/base/socketadapters.h View 2 chunks +6 lines, -5 lines 0 comments Download
M webrtc/base/socketadapters.cc View 10 chunks +14 lines, -14 lines 0 comments Download
M webrtc/libjingle/xmpp/xmppsocket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/libjingle/xmpp/xmppsocket.cc View 4 chunks +13 lines, -7 lines 0 comments Download
M webrtc/media/base/rtpdump.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/rtpdump.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M webrtc/media/base/rtpdump_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/base/testutils.h View 3 chunks +6 lines, -5 lines 0 comments Download
M webrtc/media/base/testutils.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M webrtc/media/base/videoengine_unittest.h View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/h264_bitstream_parser.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/h264_sps_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/port.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 20 chunks +33 lines, -30 lines 0 comments Download
M webrtc/p2p/base/pseudotcp.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/relayport.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/relayserver.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/base/relayserver_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M webrtc/p2p/base/stun.h View 10 chunks +20 lines, -20 lines 0 comments Download
M webrtc/p2p/base/stun.cc View 18 chunks +22 lines, -21 lines 0 comments Download
M webrtc/p2p/base/stun_unittest.cc View 18 chunks +40 lines, -32 lines 0 comments Download
M webrtc/p2p/base/stunrequest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/stunserver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/stunserver_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/turnport.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/turnserver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/turnserver.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/p2p/stunprober/stunprober.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
joachim
Ptal
4 years, 9 months ago (2016-03-21 22:49:57 UTC) #2
kjellander_webrtc
On 2016/03/21 22:49:57, joachim wrote: > Ptal Android failures caused by https://codereview.chromium.org/1818083003/ which has now ...
4 years, 9 months ago (2016-03-22 10:24:57 UTC) #4
joachim
On 2016/03/21 22:49:57, joachim wrote: > Ptal Friendly ping :)
4 years, 8 months ago (2016-03-30 10:08:09 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821083002/1
4 years, 8 months ago (2016-03-30 11:09:46 UTC) #8
tommi
lgtm
4 years, 8 months ago (2016-03-30 11:42:55 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 13:31:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821083002/1
4 years, 8 months ago (2016-03-30 13:38:58 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 13:43:42 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 13:43:55 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1f87203d703445ca52ef77d28b7ef0591f79cab
Cr-Commit-Position: refs/heads/master@{#12160}

Powered by Google App Engine
This is Rietveld 408576698