Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: webrtc/media/base/videoengine_unittest.h

Issue 1821083002: Split ByteBuffer into writer/reader objects. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/base/testutils.cc ('k') | webrtc/modules/rtp_rtcp/source/h264_bitstream_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/videoengine_unittest.h
diff --git a/webrtc/media/base/videoengine_unittest.h b/webrtc/media/base/videoengine_unittest.h
index 10459db074342941963fe692f201c62a5e51dfe5..dd827b79aea63e0b007f1e68f03765d046e821f1 100644
--- a/webrtc/media/base/videoengine_unittest.h
+++ b/webrtc/media/base/videoengine_unittest.h
@@ -279,8 +279,7 @@ class VideoMediaChannelTest : public testing::Test,
uint32_t* tstamp,
uint32_t* ssrc,
std::string* payload) {
- // TODO(jbauch): avoid copying the buffer data into the ByteBuffer
- rtc::ByteBuffer buf(p->data<char>(), p->size());
+ rtc::ByteBufferReader buf(p->data<char>(), p->size());
uint8_t u08 = 0;
uint16_t u16 = 0;
uint32_t u32 = 0;
@@ -340,8 +339,7 @@ class VideoMediaChannelTest : public testing::Test,
int count = 0;
for (int i = start_index; i < stop_index; ++i) {
std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtcpPacket(i));
- // TODO(jbauch): avoid copying the buffer data into the ByteBuffer
- rtc::ByteBuffer buf(p->data<char>(), p->size());
+ rtc::ByteBufferReader buf(p->data<char>(), p->size());
size_t total_len = 0;
// The packet may be a compound RTCP packet.
while (total_len < p->size()) {
« no previous file with comments | « webrtc/media/base/testutils.cc ('k') | webrtc/modules/rtp_rtcp/source/h264_bitstream_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698