Split ByteBuffer into writer/reader objects.

webrtc/media/base/videoengine_unittest.h

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 261 matching lines @@
     ParseRtpPacket(p, NULL, &pt, NULL, NULL, NULL, NULL);
     return pt;
   }
   static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
                              bool* x,
                              int* pt,
                              int* seqnum,
                              uint32_t* tstamp,
                              uint32_t* ssrc,
                              std::string* payload) {
-    // TODO(jbauch): avoid copying the buffer data into the ByteBuffer
-    rtc::ByteBuffer buf(p->data<char>(), p->size());
+    rtc::ByteBufferReader buf(p->data<char>(), p->size());
     uint8_t u08 = 0;
     uint16_t u16 = 0;
     uint32_t u32 = 0;
 
     // Read X and CC fields.
     if (!buf.ReadUInt8(&u08)) return false;
     bool extension = ((u08 & 0x10) != 0);
     uint8_t cc = (u08 & 0x0F);
     if (x) *x = extension;
 
@@ skipping 39 matching lines @@
     return true;
   }
 
   // Parse all RTCP packet, from start_index to stop_index, and count how many
   // FIR (PT=206 and FMT=4 according to RFC 5104). If successful, set the count
   // and return true.
   bool CountRtcpFir(int start_index, int stop_index, int* fir_count) {
     int count = 0;
     for (int i = start_index; i < stop_index; ++i) {
       std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtcpPacket(i));
-      // TODO(jbauch): avoid copying the buffer data into the ByteBuffer
-      rtc::ByteBuffer buf(p->data<char>(), p->size());
+      rtc::ByteBufferReader buf(p->data<char>(), p->size());
       size_t total_len = 0;
       // The packet may be a compound RTCP packet.
       while (total_len < p->size()) {
         // Read FMT, type and length.
         uint8_t fmt = 0;
         uint8_t type = 0;
         uint16_t length = 0;
         if (!buf.ReadUInt8(&fmt)) return false;
         fmt &= 0x1F;
         if (!buf.ReadUInt8(&type)) return false;
@@ skipping 832 matching lines @@
   std::unique_ptr<C> channel_;
   cricket::FakeNetworkInterface network_interface_;
   cricket::FakeVideoRenderer renderer_;
   cricket::VideoMediaChannel::Error media_error_;
 
   // Used by test cases where 2 streams are run on the same channel.
   cricket::FakeVideoRenderer renderer2_;
 };
 
 #endif  // WEBRTC_MEDIA_BASE_VIDEOENGINE_UNITTEST_H_  NOLINT