Split ByteBuffer into writer/reader objects.

webrtc/media/base/rtpdump_unittest.cc

 /*
  *  Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include <memory>
 #include <string>
 
 #include "webrtc/base/bytebuffer.h"
 #include "webrtc/base/gunit.h"
 #include "webrtc/base/thread.h"
 #include "webrtc/media/base/rtpdump.h"
 #include "webrtc/media/base/rtputils.h"
 #include "webrtc/media/base/testutils.h"
 
 namespace cricket {
 
 static const uint32_t kTestSsrc = 1;
 
 // Test that we read the correct header fields from the RTP/RTCP packet.
 TEST(RtpDumpTest, ReadRtpDumpPacket) {
-  rtc::ByteBuffer rtp_buf;
+  rtc::ByteBufferWriter rtp_buf;
   RtpTestUtility::kTestRawRtpPackets[0].WriteToByteBuffer(kTestSsrc, &rtp_buf);
   RtpDumpPacket rtp_packet(rtp_buf.Data(), rtp_buf.Length(), 0, false);
 
   int payload_type;
   int seq_num;
   uint32_t ts;
   uint32_t ssrc;
   int rtcp_type;
   EXPECT_FALSE(rtp_packet.is_rtcp());
   EXPECT_TRUE(rtp_packet.IsValidRtpPacket());
   EXPECT_FALSE(rtp_packet.IsValidRtcpPacket());
   EXPECT_TRUE(rtp_packet.GetRtpPayloadType(&payload_type));
   EXPECT_EQ(0, payload_type);
   EXPECT_TRUE(rtp_packet.GetRtpSeqNum(&seq_num));
   EXPECT_EQ(0, seq_num);
   EXPECT_TRUE(rtp_packet.GetRtpTimestamp(&ts));
   EXPECT_EQ(0U, ts);
   EXPECT_TRUE(rtp_packet.GetRtpSsrc(&ssrc));
   EXPECT_EQ(kTestSsrc, ssrc);
   EXPECT_FALSE(rtp_packet.GetRtcpType(&rtcp_type));
 
-  rtc::ByteBuffer rtcp_buf;
+  rtc::ByteBufferWriter rtcp_buf;
   RtpTestUtility::kTestRawRtcpPackets[0].WriteToByteBuffer(&rtcp_buf);
   RtpDumpPacket rtcp_packet(rtcp_buf.Data(), rtcp_buf.Length(), 0, true);
 
   EXPECT_TRUE(rtcp_packet.is_rtcp());
   EXPECT_FALSE(rtcp_packet.IsValidRtpPacket());
   EXPECT_TRUE(rtcp_packet.IsValidRtcpPacket());
   EXPECT_TRUE(rtcp_packet.GetRtcpType(&rtcp_type));
   EXPECT_EQ(0, rtcp_type);
 }
 
@@ skipping 213 matching lines @@
 
   // The loop reader reads three packets from the input stream.
   stream.Rewind();
   RtpDumpLoopReader loop_reader(&stream);
   EXPECT_EQ(rtc::SR_SUCCESS, loop_reader.ReadPacket(&packet));
   EXPECT_EQ(rtc::SR_SUCCESS, loop_reader.ReadPacket(&packet));
   EXPECT_EQ(rtc::SR_SUCCESS, loop_reader.ReadPacket(&packet));
 }
 
 }  // namespace cricket