Disable tests failing under UBSan to enable deployment to main waterfall.

Disable tests failing under UBSan to enable deployment to main waterfall.

modules_unittests: https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/1138/steps/modules_unittests/logs/stdio
[ RUN      ] ByteIoTest.Test64SBitBigEndian
../../webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:34:33: runtime error: shift exponent 64 is too large for 64-bit type 'long'

rtc_unittests: https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/1138/steps/rtc_unittests/logs/stdio
[ RUN      ] IPAddressTest.TestCountIPMaskBits
../../webrtc/base/ipaddress.cc:415:20: runtime error: negation of -2147483648 cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to negate this value to itself

[ RUN      ] BandwidthSmootherTest.TestSampleRollover
../../webrtc/base/rollingaccumulator.h:73:22: runtime error: signed integer overflow: 2147483647 * 2147483647 cannot be represented in type 'int'

[ RUN      ] RandomNumberGeneratorTest.UniformSignedInterval
../../webrtc/base/random_unittest.cc:121:50: runtime error: signed integer overflow: 2147483647 - -2147483648 cannot be represented in type 'int'

rtc_media_unittests: https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/1138/steps/rtc_media_unittests/logs/stdio
[ RUN      ] VideoCommonTest.TestComputeScaleWithHighFps
../../webrtc/media/base/videocommon.cc:75:34: runtime error: signed integer overflow: 2621440 - -2147483648 cannot be represented in type 'int'

BUG=webrtc:5487, webrtc:5490, webrtc:5491
NOTRY=True
R=pbos@webrtc.org
TBR=henrika@webrtc.org

Committed: https://crrev.com/a2644c06ee28c97ab670d59c416e59b8325fc678
Cr-Commit-Position: refs/heads/master@{#11764}

[kjellander_webrtc, 2016-02-25 08:59:18]

Description was changed from

==========
Suppress remaining UBSan errors to enable deployment to main waterfall.

modules_unittests:
[ RUN      ] ByteIoTest.Test64SBitBigEndian
../../webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:34:33: runtime error:
shift exponent 64 is too large for 64-bit type 'long'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

rtc_unittests:
[ RUN      ] IPAddressTest.TestCountIPMaskBits
../../webrtc/base/ipaddress.cc:415:20: runtime error: negation of -2147483648
cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to
negate this value to itself
[1/1231] IPAddressTest.TestCountIPMaskBits returned/aborted with exit code 1 (20
ms)
[2/1231] BandwidthSmootherTest.TestSampleRollover (25 ms)
Note: Google Test filter = BandwidthSmootherTest.TestSampleRollover
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from BandwidthSmootherTest
[ RUN      ] BandwidthSmootherTest.TestSampleRollover
../../webrtc/base/rollingaccumulator.h:73:22: runtime error: signed integer
overflow: 2147483647 * 2147483647 cannot be represented in type 'int'
[2/1231] BandwidthSmootherTest.TestSampleRollover returned/aborted with exit
code 1 (25 ms)
[3/1231] RandomNumberGeneratorTest.UniformSignedInterval (27 ms)
Note: Google Test filter = RandomNumberGeneratorTest.UniformSignedInterval
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from RandomNumberGeneratorTest
[ RUN      ] RandomNumberGeneratorTest.UniformSignedInterval
../../webrtc/base/random_unittest.cc:121:50: runtime error: signed integer
overflow: 2147483647 - -2147483648 cannot be represented in type 'int'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

rtc_media_unittests:
[ RUN      ] VideoCommonTest.TestComputeScaleWithHighFps
../../webrtc/media/base/videocommon.cc:75:34: runtime error: signed integer
overflow: 2621440 - -2147483648 cannot be represented in type 'int'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

BUG=webrtc:5487, webrtc:5490, webrtc:5491
==========

to

==========
Suppress remaining UBSan errors to enable deployment to main waterfall.

modules_unittests:
[ RUN      ] ByteIoTest.Test64SBitBigEndian
../../webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:34:33: runtime error:
shift exponent 64 is too large for 64-bit type 'long'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

rtc_unittests:
[ RUN      ] IPAddressTest.TestCountIPMaskBits
../../webrtc/base/ipaddress.cc:415:20: runtime error: negation of -2147483648
cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to
negate this value to itself
[1/1231] IPAddressTest.TestCountIPMaskBits returned/aborted with exit code 1 (20
ms)
[2/1231] BandwidthSmootherTest.TestSampleRollover (25 ms)
Note: Google Test filter = BandwidthSmootherTest.TestSampleRollover
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from BandwidthSmootherTest
[ RUN      ] BandwidthSmootherTest.TestSampleRollover
../../webrtc/base/rollingaccumulator.h:73:22: runtime error: signed integer
overflow: 2147483647 * 2147483647 cannot be represented in type 'int'
[2/1231] BandwidthSmootherTest.TestSampleRollover returned/aborted with exit
code 1 (25 ms)
[3/1231] RandomNumberGeneratorTest.UniformSignedInterval (27 ms)
Note: Google Test filter = RandomNumberGeneratorTest.UniformSignedInterval
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from RandomNumberGeneratorTest
[ RUN      ] RandomNumberGeneratorTest.UniformSignedInterval
../../webrtc/base/random_unittest.cc:121:50: runtime error: signed integer
overflow: 2147483647 - -2147483648 cannot be represented in type 'int'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

rtc_media_unittests:
[ RUN      ] VideoCommonTest.TestComputeScaleWithHighFps
../../webrtc/media/base/videocommon.cc:75:34: runtime error: signed integer
overflow: 2621440 - -2147483648 cannot be represented in type 'int'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

BUG=webrtc:5487, webrtc:5490, webrtc:5491
NOTRY=True
==========

[kjellander_webrtc, 2016-02-25 08:59:19]

kjellander@webrtc.org changed reviewers:
+ pbos@webrtc.org

[kjellander_webrtc, 2016-02-25 10:21:16]

It's green!

[pbos-webrtc, 2016-02-25 11:49:19]

On 2016/02/25 10:21:16, kjellander (webrtc) wrote:
> It's green!

If these only trigger in single tests, can you ifdef out the tests under ubsan
instead so we don't add larger blacklisting than we have to?

[kjellander_webrtc, 2016-02-25 12:48:46]

Description was changed from

==========
Suppress remaining UBSan errors to enable deployment to main waterfall.

modules_unittests:
[ RUN      ] ByteIoTest.Test64SBitBigEndian
../../webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:34:33: runtime error:
shift exponent 64 is too large for 64-bit type 'long'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

rtc_unittests:
[ RUN      ] IPAddressTest.TestCountIPMaskBits
../../webrtc/base/ipaddress.cc:415:20: runtime error: negation of -2147483648
cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to
negate this value to itself
[1/1231] IPAddressTest.TestCountIPMaskBits returned/aborted with exit code 1 (20
ms)
[2/1231] BandwidthSmootherTest.TestSampleRollover (25 ms)
Note: Google Test filter = BandwidthSmootherTest.TestSampleRollover
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from BandwidthSmootherTest
[ RUN      ] BandwidthSmootherTest.TestSampleRollover
../../webrtc/base/rollingaccumulator.h:73:22: runtime error: signed integer
overflow: 2147483647 * 2147483647 cannot be represented in type 'int'
[2/1231] BandwidthSmootherTest.TestSampleRollover returned/aborted with exit
code 1 (25 ms)
[3/1231] RandomNumberGeneratorTest.UniformSignedInterval (27 ms)
Note: Google Test filter = RandomNumberGeneratorTest.UniformSignedInterval
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from RandomNumberGeneratorTest
[ RUN      ] RandomNumberGeneratorTest.UniformSignedInterval
../../webrtc/base/random_unittest.cc:121:50: runtime error: signed integer
overflow: 2147483647 - -2147483648 cannot be represented in type 'int'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

rtc_media_unittests:
[ RUN      ] VideoCommonTest.TestComputeScaleWithHighFps
../../webrtc/media/base/videocommon.cc:75:34: runtime error: signed integer
overflow: 2621440 - -2147483648 cannot be represented in type 'int'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

BUG=webrtc:5487, webrtc:5490, webrtc:5491
NOTRY=True
==========

to

==========
Disable tests failing under UBSan to enable deployment to main waterfall.

modules_unittests:
[ RUN      ] ByteIoTest.Test64SBitBigEndian
../../webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:34:33: runtime error:
shift exponent 64 is too large for 64-bit type 'long'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

rtc_unittests:
[ RUN      ] IPAddressTest.TestCountIPMaskBits
../../webrtc/base/ipaddress.cc:415:20: runtime error: negation of -2147483648
cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to
negate this value to itself
[1/1231] IPAddressTest.TestCountIPMaskBits returned/aborted with exit code 1 (20
ms)
[2/1231] BandwidthSmootherTest.TestSampleRollover (25 ms)
Note: Google Test filter = BandwidthSmootherTest.TestSampleRollover
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from BandwidthSmootherTest
[ RUN      ] BandwidthSmootherTest.TestSampleRollover
../../webrtc/base/rollingaccumulator.h:73:22: runtime error: signed integer
overflow: 2147483647 * 2147483647 cannot be represented in type 'int'
[2/1231] BandwidthSmootherTest.TestSampleRollover returned/aborted with exit
code 1 (25 ms)
[3/1231] RandomNumberGeneratorTest.UniformSignedInterval (27 ms)
Note: Google Test filter = RandomNumberGeneratorTest.UniformSignedInterval
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from RandomNumberGeneratorTest
[ RUN      ] RandomNumberGeneratorTest.UniformSignedInterval
../../webrtc/base/random_unittest.cc:121:50: runtime error: signed integer
overflow: 2147483647 - -2147483648 cannot be represented in type 'int'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

rtc_media_unittests:
[ RUN      ] VideoCommonTest.TestComputeScaleWithHighFps
../../webrtc/media/base/videocommon.cc:75:34: runtime error: signed integer
overflow: 2621440 - -2147483648 cannot be represented in type 'int'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

BUG=webrtc:5487, webrtc:5490, webrtc:5491
NOTRY=True
==========

[kjellander_webrtc, 2016-02-25 12:50:07]

Patchset #3 (id:40001) has been deleted

[kjellander_webrtc, 2016-02-25 12:56:57]

Description was changed from

==========
Disable tests failing under UBSan to enable deployment to main waterfall.

modules_unittests:
[ RUN      ] ByteIoTest.Test64SBitBigEndian
../../webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:34:33: runtime error:
shift exponent 64 is too large for 64-bit type 'long'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

rtc_unittests:
[ RUN      ] IPAddressTest.TestCountIPMaskBits
../../webrtc/base/ipaddress.cc:415:20: runtime error: negation of -2147483648
cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to
negate this value to itself
[1/1231] IPAddressTest.TestCountIPMaskBits returned/aborted with exit code 1 (20
ms)
[2/1231] BandwidthSmootherTest.TestSampleRollover (25 ms)
Note: Google Test filter = BandwidthSmootherTest.TestSampleRollover
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from BandwidthSmootherTest
[ RUN      ] BandwidthSmootherTest.TestSampleRollover
../../webrtc/base/rollingaccumulator.h:73:22: runtime error: signed integer
overflow: 2147483647 * 2147483647 cannot be represented in type 'int'
[2/1231] BandwidthSmootherTest.TestSampleRollover returned/aborted with exit
code 1 (25 ms)
[3/1231] RandomNumberGeneratorTest.UniformSignedInterval (27 ms)
Note: Google Test filter = RandomNumberGeneratorTest.UniformSignedInterval
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from RandomNumberGeneratorTest
[ RUN      ] RandomNumberGeneratorTest.UniformSignedInterval
../../webrtc/base/random_unittest.cc:121:50: runtime error: signed integer
overflow: 2147483647 - -2147483648 cannot be represented in type 'int'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

rtc_media_unittests:
[ RUN      ] VideoCommonTest.TestComputeScaleWithHighFps
../../webrtc/media/base/videocommon.cc:75:34: runtime error: signed integer
overflow: 2621440 - -2147483648 cannot be represented in type 'int'
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...

BUG=webrtc:5487, webrtc:5490, webrtc:5491
NOTRY=True
==========

to

==========
Disable tests failing under UBSan to enable deployment to main waterfall.

modules_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] ByteIoTest.Test64SBitBigEndian
../../webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:34:33: runtime error:
shift exponent 64 is too large for 64-bit type 'long'

rtc_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] IPAddressTest.TestCountIPMaskBits
../../webrtc/base/ipaddress.cc:415:20: runtime error: negation of -2147483648
cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to
negate this value to itself

[ RUN      ] BandwidthSmootherTest.TestSampleRollover
../../webrtc/base/rollingaccumulator.h:73:22: runtime error: signed integer
overflow: 2147483647 * 2147483647 cannot be represented in type 'int'

[ RUN      ] RandomNumberGeneratorTest.UniformSignedInterval
../../webrtc/base/random_unittest.cc:121:50: runtime error: signed integer
overflow: 2147483647 - -2147483648 cannot be represented in type 'int'

rtc_media_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] VideoCommonTest.TestComputeScaleWithHighFps
../../webrtc/media/base/videocommon.cc:75:34: runtime error: signed integer
overflow: 2621440 - -2147483648 cannot be represented in type 'int'

BUG=webrtc:5487, webrtc:5490, webrtc:5491
NOTRY=True
==========

[kjellander_webrtc, 2016-02-25 13:06:52]

On 2016/02/25 11:49:19, pbos-webrtc wrote:
> On 2016/02/25 10:21:16, kjellander (webrtc) wrote:
> > It's green!
> 
> If these only trigger in single tests, can you ifdef out the tests under ubsan
> instead so we don't add larger blacklisting than we have to?

You're absolutely right. Thanks for pushing for good engineering. PS#3 does this
now.

[pbos-webrtc, 2016-02-25 13:08:52]

lgtm, thanks

[kjellander_webrtc, 2016-02-25 13:22:42]

kjellander@webrtc.org changed reviewers:
+ henrika@webrtc.org

[kjellander_webrtc, 2016-02-25 13:22:43]

TBRing henrika for root owners

[kjellander_webrtc, 2016-02-25 13:23:01]

Description was changed from

==========
Disable tests failing under UBSan to enable deployment to main waterfall.

modules_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] ByteIoTest.Test64SBitBigEndian
../../webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:34:33: runtime error:
shift exponent 64 is too large for 64-bit type 'long'

rtc_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] IPAddressTest.TestCountIPMaskBits
../../webrtc/base/ipaddress.cc:415:20: runtime error: negation of -2147483648
cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to
negate this value to itself

[ RUN      ] BandwidthSmootherTest.TestSampleRollover
../../webrtc/base/rollingaccumulator.h:73:22: runtime error: signed integer
overflow: 2147483647 * 2147483647 cannot be represented in type 'int'

[ RUN      ] RandomNumberGeneratorTest.UniformSignedInterval
../../webrtc/base/random_unittest.cc:121:50: runtime error: signed integer
overflow: 2147483647 - -2147483648 cannot be represented in type 'int'

rtc_media_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] VideoCommonTest.TestComputeScaleWithHighFps
../../webrtc/media/base/videocommon.cc:75:34: runtime error: signed integer
overflow: 2621440 - -2147483648 cannot be represented in type 'int'

BUG=webrtc:5487, webrtc:5490, webrtc:5491
NOTRY=True
==========

to

==========
Disable tests failing under UBSan to enable deployment to main waterfall.

modules_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] ByteIoTest.Test64SBitBigEndian
../../webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:34:33: runtime error:
shift exponent 64 is too large for 64-bit type 'long'

rtc_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] IPAddressTest.TestCountIPMaskBits
../../webrtc/base/ipaddress.cc:415:20: runtime error: negation of -2147483648
cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to
negate this value to itself

[ RUN      ] BandwidthSmootherTest.TestSampleRollover
../../webrtc/base/rollingaccumulator.h:73:22: runtime error: signed integer
overflow: 2147483647 * 2147483647 cannot be represented in type 'int'

[ RUN      ] RandomNumberGeneratorTest.UniformSignedInterval
../../webrtc/base/random_unittest.cc:121:50: runtime error: signed integer
overflow: 2147483647 - -2147483648 cannot be represented in type 'int'

rtc_media_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] VideoCommonTest.TestComputeScaleWithHighFps
../../webrtc/media/base/videocommon.cc:75:34: runtime error: signed integer
overflow: 2621440 - -2147483648 cannot be represented in type 'int'

BUG=webrtc:5487, webrtc:5490, webrtc:5491
NOTRY=True
TBR=henrika@webrtc.org
==========

[kjellander_webrtc, 2016-02-25 13:23:32]

Description was changed from

==========
Disable tests failing under UBSan to enable deployment to main waterfall.

modules_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] ByteIoTest.Test64SBitBigEndian
../../webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:34:33: runtime error:
shift exponent 64 is too large for 64-bit type 'long'

rtc_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] IPAddressTest.TestCountIPMaskBits
../../webrtc/base/ipaddress.cc:415:20: runtime error: negation of -2147483648
cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to
negate this value to itself

[ RUN      ] BandwidthSmootherTest.TestSampleRollover
../../webrtc/base/rollingaccumulator.h:73:22: runtime error: signed integer
overflow: 2147483647 * 2147483647 cannot be represented in type 'int'

[ RUN      ] RandomNumberGeneratorTest.UniformSignedInterval
../../webrtc/base/random_unittest.cc:121:50: runtime error: signed integer
overflow: 2147483647 - -2147483648 cannot be represented in type 'int'

rtc_media_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] VideoCommonTest.TestComputeScaleWithHighFps
../../webrtc/media/base/videocommon.cc:75:34: runtime error: signed integer
overflow: 2621440 - -2147483648 cannot be represented in type 'int'

BUG=webrtc:5487, webrtc:5490, webrtc:5491
NOTRY=True
TBR=henrika@webrtc.org
==========

to

==========
Disable tests failing under UBSan to enable deployment to main waterfall.

modules_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] ByteIoTest.Test64SBitBigEndian
../../webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:34:33: runtime error:
shift exponent 64 is too large for 64-bit type 'long'

rtc_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] IPAddressTest.TestCountIPMaskBits
../../webrtc/base/ipaddress.cc:415:20: runtime error: negation of -2147483648
cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to
negate this value to itself

[ RUN      ] BandwidthSmootherTest.TestSampleRollover
../../webrtc/base/rollingaccumulator.h:73:22: runtime error: signed integer
overflow: 2147483647 * 2147483647 cannot be represented in type 'int'

[ RUN      ] RandomNumberGeneratorTest.UniformSignedInterval
../../webrtc/base/random_unittest.cc:121:50: runtime error: signed integer
overflow: 2147483647 - -2147483648 cannot be represented in type 'int'

rtc_media_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] VideoCommonTest.TestComputeScaleWithHighFps
../../webrtc/media/base/videocommon.cc:75:34: runtime error: signed integer
overflow: 2621440 - -2147483648 cannot be represented in type 'int'

BUG=webrtc:5487, webrtc:5490, webrtc:5491
NOTRY=True
R=pbos@webrtc.org
TBR=henrika@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/a2644c06ee28c97ab670d59c4...
==========

[kjellander_webrtc, 2016-02-25 13:23:33]

Committed patchset #3 (id:60001) manually as
a2644c06ee28c97ab670d59c416e59b8325fc678 (presubmit successful).

[commit-bot: I haz the power, 2016-02-25 13:23:34]

Description was changed from

==========
Disable tests failing under UBSan to enable deployment to main waterfall.

modules_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] ByteIoTest.Test64SBitBigEndian
../../webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:34:33: runtime error:
shift exponent 64 is too large for 64-bit type 'long'

rtc_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] IPAddressTest.TestCountIPMaskBits
../../webrtc/base/ipaddress.cc:415:20: runtime error: negation of -2147483648
cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to
negate this value to itself

[ RUN      ] BandwidthSmootherTest.TestSampleRollover
../../webrtc/base/rollingaccumulator.h:73:22: runtime error: signed integer
overflow: 2147483647 * 2147483647 cannot be represented in type 'int'

[ RUN      ] RandomNumberGeneratorTest.UniformSignedInterval
../../webrtc/base/random_unittest.cc:121:50: runtime error: signed integer
overflow: 2147483647 - -2147483648 cannot be represented in type 'int'

rtc_media_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] VideoCommonTest.TestComputeScaleWithHighFps
../../webrtc/media/base/videocommon.cc:75:34: runtime error: signed integer
overflow: 2621440 - -2147483648 cannot be represented in type 'int'

BUG=webrtc:5487, webrtc:5490, webrtc:5491
NOTRY=True
R=pbos@webrtc.org
TBR=henrika@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/a2644c06ee28c97ab670d59c4...
==========

to

==========
Disable tests failing under UBSan to enable deployment to main waterfall.

modules_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] ByteIoTest.Test64SBitBigEndian
../../webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc:34:33: runtime error:
shift exponent 64 is too large for 64-bit type 'long'

rtc_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] IPAddressTest.TestCountIPMaskBits
../../webrtc/base/ipaddress.cc:415:20: runtime error: negation of -2147483648
cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to
negate this value to itself

[ RUN      ] BandwidthSmootherTest.TestSampleRollover
../../webrtc/base/rollingaccumulator.h:73:22: runtime error: signed integer
overflow: 2147483647 * 2147483647 cannot be represented in type 'int'

[ RUN      ] RandomNumberGeneratorTest.UniformSignedInterval
../../webrtc/base/random_unittest.cc:121:50: runtime error: signed integer
overflow: 2147483647 - -2147483648 cannot be represented in type 'int'

rtc_media_unittests:
https://build.chromium.org/p/client.webrtc.fyi/builders/Linux%20UBSan/builds/...
[ RUN      ] VideoCommonTest.TestComputeScaleWithHighFps
../../webrtc/media/base/videocommon.cc:75:34: runtime error: signed integer
overflow: 2621440 - -2147483648 cannot be represented in type 'int'

BUG=webrtc:5487, webrtc:5490, webrtc:5491
NOTRY=True
R=pbos@webrtc.org
TBR=henrika@webrtc.org

Committed: https://crrev.com/a2644c06ee28c97ab670d59c416e59b8325fc678
Cr-Commit-Position: refs/heads/master@{#11764}
==========

[commit-bot: I haz the power, 2016-02-25 13:23:35]

Patchset 3 (id:??) landed as
https://crrev.com/a2644c06ee28c97ab670d59c416e59b8325fc678
Cr-Commit-Position: refs/heads/master@{#11764}

[henrika_webrtc, 2016-02-25 13:30:19]

LGTM