webrtc/media/base/videocommon_unittest.cc - Issue 1727233005: Disable tests failing under UBSan to enable deployment to main waterfall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/base/videocommon_unittest.cc

Issue 1727233005: Disable tests failing under UBSan to enable deployment to main waterfall. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Disabled only failing tests instead of blacklisting Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/media/base/videocommon_unittest.cc

diff --git a/webrtc/media/base/videocommon_unittest.cc b/webrtc/media/base/videocommon_unittest.cc

index 72b828c028ed7cfe347693624122864b2409fc40..84a728b19b14da8b5e45efd3657da7faaac6cf29 100644

--- a/webrtc/media/base/videocommon_unittest.cc

+++ b/webrtc/media/base/videocommon_unittest.cc

@@ -126,7 +126,13 @@ TEST(VideoCommonTest, TestComputeScaleWithLowFps) {

}

// Same as TestComputeScale but with 15 fps instead of 5 fps.

-TEST(VideoCommonTest, TestComputeScaleWithHighFps) {

+// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5487

+#ifdef UNDEFINED_SANITIZER

+#define MAYBE_TestComputeScaleWithHighFps DISABLED_TestComputeScaleWithHighFps

+#else

+#define MAYBE_TestComputeScaleWithHighFps TestComputeScaleWithHighFps

+#endif

+TEST(VideoCommonTest, MAYBE_TestComputeScaleWithHighFps) {

int scaled_width, scaled_height;

// Request small enough but high fps. Expect 1/2 size.

« no previous file with comments | « webrtc/base/random_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/byte_io_unittest.cc » ('j') | no next file with comments »