Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: webrtc/base/random_unittest.cc

Issue 1727233005: Disable tests failing under UBSan to enable deployment to main waterfall. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Disabled only failing tests instead of blacklisting Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/ipaddress_unittest.cc ('k') | webrtc/media/base/videocommon_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/random_unittest.cc
diff --git a/webrtc/base/random_unittest.cc b/webrtc/base/random_unittest.cc
index febae1c28f13ca856e547d52f9164c89a9c2ba3b..3b47a00806eb0fc29ae0e43568df0f8b19fde960 100644
--- a/webrtc/base/random_unittest.cc
+++ b/webrtc/base/random_unittest.cc
@@ -198,7 +198,13 @@ TEST(RandomNumberGeneratorTest, UniformUnsignedInterval) {
BucketTestUnsignedInterval(1000, 1000000, 0, 2147483999, 4, &prng);
}
-TEST(RandomNumberGeneratorTest, UniformSignedInterval) {
+// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5491
+#ifdef UNDEFINED_SANITIZER
+#define MAYBE_UniformSignedInterval DISABLED_UniformSignedInterval
+#else
+#define MAYBE_UniformSignedInterval UniformSignedInterval
+#endif
+TEST(RandomNumberGeneratorTest, MAYBE_UniformSignedInterval) {
Random prng(66260695729ull);
BucketTestSignedInterval(2, 100000, 0, 1, 3, &prng);
BucketTestSignedInterval(7, 100000, -2, 4, 3, &prng);
« no previous file with comments | « webrtc/base/ipaddress_unittest.cc ('k') | webrtc/media/base/videocommon_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698