webrtc/base/ipaddress_unittest.cc - Issue 1727233005: Disable tests failing under UBSan to enable deployment to main waterfall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/ipaddress_unittest.cc

Issue 1727233005: Disable tests failing under UBSan to enable deployment to main waterfall. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Disabled only failing tests instead of blacklisting Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/ipaddress_unittest.cc

diff --git a/webrtc/base/ipaddress_unittest.cc b/webrtc/base/ipaddress_unittest.cc

index 62773c143a7dbce9d100b655896766fbc36e50ba..cbe8f2654806ba697d00fac29f92dafad693dd2f 100644

--- a/webrtc/base/ipaddress_unittest.cc

+++ b/webrtc/base/ipaddress_unittest.cc

@@ -669,7 +669,13 @@ TEST(IPAddressTest, TestAsIPv6Address) {

EXPECT_EQ(addr, addr2);

}

-TEST(IPAddressTest, TestCountIPMaskBits) {

+// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5491

+#ifdef UNDEFINED_SANITIZER

+#define MAYBE_TestCountIPMaskBits DISABLED_TestCountIPMaskBits

+#else

+#define MAYBE_TestCountIPMaskBits TestCountIPMaskBits

+#endif

+TEST(IPAddressTest, MAYBE_TestCountIPMaskBits) {

IPAddress mask;

// IPv4 on byte boundaries

EXPECT_PRED2(CheckMaskCount, "255.255.255.255", 32);

« no previous file with comments | « webrtc/base/bandwidthsmoother_unittest.cc ('k') | webrtc/base/random_unittest.cc » ('j') | no next file with comments »