Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: webrtc/base/bandwidthsmoother_unittest.cc

Issue 1727233005: Disable tests failing under UBSan to enable deployment to main waterfall. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Disabled only failing tests instead of blacklisting Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/base/ipaddress_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/bandwidthsmoother_unittest.cc
diff --git a/webrtc/base/bandwidthsmoother_unittest.cc b/webrtc/base/bandwidthsmoother_unittest.cc
index 132c0b13a7954f64d421ef72f03f17bd2c6d714d..0ac753e6a7587abce66e721ac0935e5dcf452277 100644
--- a/webrtc/base/bandwidthsmoother_unittest.cc
+++ b/webrtc/base/bandwidthsmoother_unittest.cc
@@ -88,7 +88,13 @@ TEST(BandwidthSmootherTest, TestSampleTooFewSamples) {
EXPECT_EQ(kBandwidthSample, mon.get_bandwidth_estimation());
}
-TEST(BandwidthSmootherTest, TestSampleRollover) {
+// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5491
+#ifdef UNDEFINED_SANITIZER
+#define MAYBE_TestSampleRollover DISABLED_TestSampleRollover
+#else
+#define MAYBE_TestSampleRollover TestSampleRollover
+#endif
+TEST(BandwidthSmootherTest, MAYBE_TestSampleRollover) {
const int kHugeBandwidth = 2000000000; // > INT_MAX/1.1
BandwidthSmoother mon(kHugeBandwidth,
kTimeBetweenIncrease,
« no previous file with comments | « no previous file | webrtc/base/ipaddress_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698