Remove conference_mode flag from AudioOptions and VideoOptions.

Remove conference_mode flag from AudioOptions and VideoOptions.

For audio, the flag is apparently unused. For video, the flag is moved to
VideoSendParameters, with the intention to keep only per-stream flags in
VideoOptions. The flag is used for the webrtcvideoengine2 logic commented like

  // Conference mode screencast uses 2 temporal layers split at 100kbit.

  // For screenshare in conference mode, tl0 and tl1 bitrates are piggybacked
  // on the VideoCodec struct as target and max bitrates, respectively.
  // See eg. webrtc::VP8EncoderImpl::SetRates().

BUG=webrtc:5426
Committed: https://crrev.com/4b4dc86c611e8db9b75de40d2b6ddd5f215e95ab
Cr-Commit-Position: refs/heads/master@{#11651}

[nisse-webrtc, 2016-02-15 13:19:35]

Description was changed from

==========
Remove conference_mode flag from AudioOptions and VideoOptions.

For audio, the flag is apparently unused. For video, the flag is moved
to VideoSendParameters. The flag is used for the webrtcvideoengine2
logic commented like

  // Conference mode screencast uses 2 temporal layers split at 100kbit.

  // For screenshare in conference mode, tl0 and tl1 bitrates are piggybacked
  // on the VideoCodec struct as target and max bitrates, respectively.
  // See eg. webrtc::VP8EncoderImpl::SetRates().

BUG=webrtc:5426
==========

to

==========
Remove conference_mode flag from AudioOptions and VideoOptions.

For audio, the flag is apparently unused. For video, the flag is moved to
VideoSendParameters, with the intention to keep only per-stream flags in
VideoOptions. The flag is used for the webrtcvideoengine2 logic commented like

  // Conference mode screencast uses 2 temporal layers split at 100kbit.

  // For screenshare in conference mode, tl0 and tl1 bitrates are piggybacked
  // on the VideoCodec struct as target and max bitrates, respectively.
  // See eg. webrtc::VP8EncoderImpl::SetRates().

BUG=webrtc:5426
==========

[nisse-webrtc, 2016-02-15 13:22:21]

nisse@webrtc.org changed reviewers:
+ pbos@webrtc.org, perkj@webrtc.org, pthatcher@webrtc.org

[nisse-webrtc, 2016-02-15 13:22:21]

Moves conference_mode, as discussed earlier.

@solenberg: This also deletes conference_mode from AudioOptions.

[pbos-webrtc, 2016-02-15 15:08:38]

lgtm

[the sun, 2016-02-15 15:25:08]

On 2016/02/15 15:08:38, pbos-webrtc wrote:
> lgtm

Nice, thank you!

[pthatcher1, 2016-02-17 06:53:58]

lgtm

Nice.  I'm glad that wasn't as messy as I was expecting.

I sure hope we can remove it completely some day, though.

[nisse-webrtc, 2016-02-17 10:51:50]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-02-17 10:51:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697163002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697163002/1

[commit-bot: I haz the power, 2016-02-17 10:58:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 10:58:58]

Try jobs failed on following builders:
  linux_ubsan_vptr on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)

[nisse-webrtc, 2016-02-17 11:22:45]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-02-17 11:22:45]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1697163002/#ps20001 (title:
"Fix logic when SetSendParameters changes conference_mode but no options.")

[commit-bot: I haz the power, 2016-02-17 11:22:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697163002/20001

[commit-bot: I haz the power, 2016-02-17 13:25:39]

Description was changed from

==========
Remove conference_mode flag from AudioOptions and VideoOptions.

For audio, the flag is apparently unused. For video, the flag is moved to
VideoSendParameters, with the intention to keep only per-stream flags in
VideoOptions. The flag is used for the webrtcvideoengine2 logic commented like

  // Conference mode screencast uses 2 temporal layers split at 100kbit.

  // For screenshare in conference mode, tl0 and tl1 bitrates are piggybacked
  // on the VideoCodec struct as target and max bitrates, respectively.
  // See eg. webrtc::VP8EncoderImpl::SetRates().

BUG=webrtc:5426
==========

to

==========
Remove conference_mode flag from AudioOptions and VideoOptions.

For audio, the flag is apparently unused. For video, the flag is moved to
VideoSendParameters, with the intention to keep only per-stream flags in
VideoOptions. The flag is used for the webrtcvideoengine2 logic commented like

  // Conference mode screencast uses 2 temporal layers split at 100kbit.

  // For screenshare in conference mode, tl0 and tl1 bitrates are piggybacked
  // on the VideoCodec struct as target and max bitrates, respectively.
  // See eg. webrtc::VP8EncoderImpl::SetRates().

BUG=webrtc:5426
==========

[commit-bot: I haz the power, 2016-02-17 13:25:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-17 13:25:49]

Description was changed from

==========
Remove conference_mode flag from AudioOptions and VideoOptions.

For audio, the flag is apparently unused. For video, the flag is moved to
VideoSendParameters, with the intention to keep only per-stream flags in
VideoOptions. The flag is used for the webrtcvideoengine2 logic commented like

  // Conference mode screencast uses 2 temporal layers split at 100kbit.

  // For screenshare in conference mode, tl0 and tl1 bitrates are piggybacked
  // on the VideoCodec struct as target and max bitrates, respectively.
  // See eg. webrtc::VP8EncoderImpl::SetRates().

BUG=webrtc:5426
==========

to

==========
Remove conference_mode flag from AudioOptions and VideoOptions.

For audio, the flag is apparently unused. For video, the flag is moved to
VideoSendParameters, with the intention to keep only per-stream flags in
VideoOptions. The flag is used for the webrtcvideoengine2 logic commented like

  // Conference mode screencast uses 2 temporal layers split at 100kbit.

  // For screenshare in conference mode, tl0 and tl1 bitrates are piggybacked
  // on the VideoCodec struct as target and max bitrates, respectively.
  // See eg. webrtc::VP8EncoderImpl::SetRates().

BUG=webrtc:5426

Committed: https://crrev.com/4b4dc86c611e8db9b75de40d2b6ddd5f215e95ab
Cr-Commit-Position: refs/heads/master@{#11651}
==========

[commit-bot: I haz the power, 2016-02-17 13:25:50]

Patchset 2 (id:??) landed as
https://crrev.com/4b4dc86c611e8db9b75de40d2b6ddd5f215e95ab
Cr-Commit-Position: refs/heads/master@{#11651}