Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: webrtc/media/engine/webrtcvideoengine2.h

Issue 1697163002: Remove conference_mode flag from AudioOptions and VideoOptions. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix logic when SetSendParameters changes conference_mode but no options. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/base/videoengine_unittest.h ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 VideoCodec codec; 185 VideoCodec codec;
186 webrtc::FecConfig fec; 186 webrtc::FecConfig fec;
187 int rtx_payload_type; 187 int rtx_payload_type;
188 }; 188 };
189 189
190 struct ChangedSendParameters { 190 struct ChangedSendParameters {
191 // These optionals are unset if not changed. 191 // These optionals are unset if not changed.
192 rtc::Optional<VideoCodecSettings> codec; 192 rtc::Optional<VideoCodecSettings> codec;
193 rtc::Optional<std::vector<webrtc::RtpExtension>> rtp_header_extensions; 193 rtc::Optional<std::vector<webrtc::RtpExtension>> rtp_header_extensions;
194 rtc::Optional<int> max_bandwidth_bps; 194 rtc::Optional<int> max_bandwidth_bps;
195 rtc::Optional<bool> conference_mode;
195 rtc::Optional<VideoOptions> options; 196 rtc::Optional<VideoOptions> options;
196 rtc::Optional<webrtc::RtcpMode> rtcp_mode; 197 rtc::Optional<webrtc::RtcpMode> rtcp_mode;
197 }; 198 };
198 199
199 struct ChangedRecvParameters { 200 struct ChangedRecvParameters {
200 // These optionals are unset if not changed. 201 // These optionals are unset if not changed.
201 rtc::Optional<std::vector<VideoCodecSettings>> codec_settings; 202 rtc::Optional<std::vector<VideoCodecSettings>> codec_settings;
202 rtc::Optional<std::vector<webrtc::RtpExtension>> rtp_header_extensions; 203 rtc::Optional<std::vector<webrtc::RtpExtension>> rtp_header_extensions;
203 rtc::Optional<webrtc::RtcpMode> rtcp_mode; 204 rtc::Optional<webrtc::RtcpMode> rtcp_mode;
204 }; 205 };
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 // similar parameters depending on which options changed etc. 267 // similar parameters depending on which options changed etc.
267 struct VideoSendStreamParameters { 268 struct VideoSendStreamParameters {
268 VideoSendStreamParameters( 269 VideoSendStreamParameters(
269 const webrtc::VideoSendStream::Config& config, 270 const webrtc::VideoSendStream::Config& config,
270 const VideoOptions& options, 271 const VideoOptions& options,
271 int max_bitrate_bps, 272 int max_bitrate_bps,
272 const rtc::Optional<VideoCodecSettings>& codec_settings); 273 const rtc::Optional<VideoCodecSettings>& codec_settings);
273 webrtc::VideoSendStream::Config config; 274 webrtc::VideoSendStream::Config config;
274 VideoOptions options; 275 VideoOptions options;
275 int max_bitrate_bps; 276 int max_bitrate_bps;
277 bool conference_mode;
276 rtc::Optional<VideoCodecSettings> codec_settings; 278 rtc::Optional<VideoCodecSettings> codec_settings;
277 // Sent resolutions + bitrates etc. by the underlying VideoSendStream, 279 // Sent resolutions + bitrates etc. by the underlying VideoSendStream,
278 // typically changes when setting a new resolution or reconfiguring 280 // typically changes when setting a new resolution or reconfiguring
279 // bitrates. 281 // bitrates.
280 webrtc::VideoEncoderConfig encoder_config; 282 webrtc::VideoEncoderConfig encoder_config;
281 }; 283 };
282 284
283 struct AllocatedEncoder { 285 struct AllocatedEncoder {
284 AllocatedEncoder(webrtc::VideoEncoder* encoder, 286 AllocatedEncoder(webrtc::VideoEncoder* encoder,
285 webrtc::VideoCodecType type, 287 webrtc::VideoCodecType type,
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
517 VideoOptions options_; 519 VideoOptions options_;
518 // TODO(deadbeef): Don't duplicate information between 520 // TODO(deadbeef): Don't duplicate information between
519 // send_params/recv_params, rtp_extensions, options, etc. 521 // send_params/recv_params, rtp_extensions, options, etc.
520 VideoSendParameters send_params_; 522 VideoSendParameters send_params_;
521 VideoRecvParameters recv_params_; 523 VideoRecvParameters recv_params_;
522 }; 524 };
523 525
524 } // namespace cricket 526 } // namespace cricket
525 527
526 #endif // WEBRTC_MEDIA_ENGINE_WEBRTCVIDEOENGINE2_H_ 528 #endif // WEBRTC_MEDIA_ENGINE_WEBRTCVIDEOENGINE2_H_
OLDNEW
« no previous file with comments | « webrtc/media/base/videoengine_unittest.h ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698